Ticket #1788 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

r48944 breaks rakudo

Reported by: pmichaud Owned by: luben
Priority: blocker Milestone:
Component: core Version: 2.7.0
Severity: fatal Keywords:
Cc: Language: perl6
Patch status: Platform:

Description

The hash_inlined_func branch merge breaks Rakudo -- we're now getting errors of the form

pmichaud@plum:~/rakudo$ ./perl6 t/spec/S04-statement-parsing/hash.rakudo
1..7
can't get class from an instance of class 'P6role'
  in 'Test::isa_ok' at line 142:Test.pm
  in main program body at line 9:t/spec/S04-statement-parsing/hash.rakudo
pmichaud@plum:~/rakudo$ ./perl6

It appears that the merge undid r48899, which itself was a revert of r48851.

I don't know what other problems are likely to arise from this branch merge, but I fear there may be several. The entire sequence from r48768 to r48909 was basically unusable by Rakudo (for multiple independent reasons), so if hash_inlined_func was based on a revision of Parrot in the middle of that sequence and wasn't re-synced with trunk (as it appears to be the case), there could be other Rakudo-critical reverts/patches that were undone by r48944.

Pm

Change History

Changed 4 years ago by luben

  • owner set to luben
  • status changed from new to assigned

Yes, the branch merge accidentally reverted some previous commits. It's strange, because I have never touched this files in my branch. I'll fix it.

Changed 4 years ago by luben

I have reviewed the diffs. I found some unintended artifacts of the branch merge. Fixed in r48982.

Changed 4 years ago by luben

  • status changed from assigned to closed
  • resolution set to fixed

Closing, as the patch fixed rakudo test that were failing because of it.

Note: See TracTickets for help on using tickets.