Ticket #1792 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

return inside void function in integer.pmc breaks build on solaris

Reported by: rg Owned by:
Priority: normal Milestone:
Component: core Version: 2.7.0
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform: solaris

Description

Change occurred in r48754. Suggested patch:

Index: src/pmc/integer.pmc
===================================================================
--- src/pmc/integer.pmc (revision 49046)
+++ src/pmc/integer.pmc (working copy)
@@ -1228,7 +1228,7 @@
         else {
             maybe_throw_overflow_error(INTERP);
             SELF = upgrade_self_to_bignum(INTERP, SELF);
-            return VTABLE_i_neg(INTERP, SELF);
+            VTABLE_i_neg(INTERP, SELF);
         }
     }

Sorry for inlining (and patch is also copy&pasted), but it's so simple it just removes the return statement.

Change History

Changed 4 years ago by NotFound

  • status changed from new to closed
  • resolution set to fixed
  • patch set to applied

Applied, thanks!

Note: See TracTickets for help on using tickets.