Ticket #1827 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Test failure in t/configure/049-options_test_prepare.t under perl < 5.8.8

Reported by: doughera Owned by: jkeenan
Priority: normal Milestone:
Component: testing Version: 2.8.0
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform:

Description

When run with a version of perl less than 5.8.8 (I tested back to 5.8.4) the test fails in the following way:

$ perl t/configure/049-options_test_prepare.t
1..12
ok 1 - Correctly named test identified
ok 2 - Incorrectly named test excluded
ok 3 - Able to change back to starting directory
ok 4 - File in incorrect directory correctly excluded from list of configuration step tests
ok 5 - File lacking 2-digit number correctly excluded from list of configuration step tests
ok 6 - File in second-level directory correctly included in list of configuration step tests
ok 7 - File containing capital letters in name correctly excluded from list of configuration step tests
not ok 8 - Got expected number of existing steps
#     Failed test (t/configure/049-options_test_prepare.t at line 86)
#          got: '8'
#     expected: '5'
ok 9 - Got expected number of missing steps
ok 10 - Got expected missing step gen::missing
ok 11 - Able to change back to starting directory
ok 12 - Completed all tests in t/configure/049-options_test_prepare.t
# Looks like you failed 1 tests of 12.

I know it is old, but perl-5.8.4 is still the default perl shipped with the current version of Solaris.

The fix appears to be simple -- each invocation of _find_steps_tests can simply initialize %steps_tests_complex . The attached patch does this.

Attachments

tt1827-Prepare.patch Download (484 bytes) - added by doughera 4 years ago.

Change History

Changed 4 years ago by doughera

  Changed 4 years ago by doughera

  • component changed from none to testing
  • patch set to new

  Changed 4 years ago by jkeenan

  • owner set to jkeenan
  • status changed from new to assigned

follow-up: ↓ 4   Changed 4 years ago by jkeenan

Andy,

I applied your patch and tested it on Linux/i386 with Perl 5.8.7, the oldest I have readily available. Applied in r49538. Can you confirm that it works for you?

Thanks.

kid51

in reply to: ↑ 3   Changed 4 years ago by doughera

  • status changed from assigned to closed
  • resolution set to fixed
  • patch changed from new to applied

I applied your patch and tested it on Linux/i386 with Perl 5.8.7, the oldest I have readily available. Applied in r49538. Can you confirm that it works for you?

Yes, it works fine for perl 5.8.4 through 5.8.9. I've closed the ticket. Thanks.

Note: See TracTickets for help on using tickets.