Ticket #1859 (closed bug: wontfix)

Opened 4 years ago

Last modified 4 years ago

'make realclean' fails to remove release tarballs

Reported by: jkeenan Owned by: jkeenan
Priority: normal Milestone: 2.10
Component: tools Version: 2.10.0
Severity: medium Keywords:
Cc: gerd Language:
Patch status: Platform: all

Description (last modified by jkeenan) (diff)

While working on TT #1850 the other day, I had occasion to invoke make release, a command which -- since I have yet to serve as Release Manager -- I had never previously invoked.

make release left me with the following files in my working directory:

parrot-2.10.0-devel.tar.bz2
parrot-2.10.0-devel.tar.bz2.sha256
parrot-2.10.0-devel.tar.gz
parrot-2.10.0-devel.tar.gz.sha256

The tarballs are, of course, quite large so I would like to remove them. However, I have invoked make realclean may times since then and the files remain. So it's obvious that these files are missing from the realclean target.

Question: Do we want these files to be removed by make realclean. Cet. par., I'd say yes. But perhaps someone who has served as Release Manager might have a different idea.

Thoughts?

kid51

Change History

  Changed 4 years ago by jkeenan

  • description modified (diff)

follow-up: ↓ 3   Changed 4 years ago by pmichaud

I can understand the reasoning here, but in general I wouldn't expect "make realclean" to clear out the release tarballs.

In the common case (someone downloads a tarball) it's not the Parrot build system that creates the tarball, so "make realclean" shouldn't delete it. It would surprise (and concern me) as a user if "make realclean" were to clear out a tarball that I created/copied into the directory myself.

Put another way, I think that being in the release manager role is a bit of a special case and that "make realclean" ought to stick with the more common "I downloaded and built Parrot" case.

Just my $0.02--

Pm

in reply to: ↑ 2   Changed 4 years ago by jkeenan

Replying to pmichaud:

In the common case (someone downloads a tarball) it's not the Parrot build system that creates the tarball, so "make realclean" shouldn't delete it.

That sounds logical to me. So I now vote that we do nothing.

kid51

  Changed 4 years ago by gerd

  • cc gerd added

  Changed 4 years ago by bacek

Hello.

+1 for pmichaud. I don't want "make realclean" to remove any "non-vcs-tracked-files" in the current directory. Especially now, when we have "git clean -dfq" combo to remove all temorary files.

-- Bacek

  Changed 4 years ago by jkeenan

  • status changed from new to assigned
  • owner changed from dukeleto to jkeenan

  Changed 4 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to wontfix

So it seems people are happy with the status quo. Closing ticket.

Note: See TracTickets for help on using tickets.