Ticket #1865 (closed cage: fixed)

Opened 4 years ago

Last modified 4 years ago

Allow more windows environments with git to work correctly with build process

Reported by: ronaldws Owned by:
Priority: normal Milestone: 2.11
Component: build Version: 2.10.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

Parrot now uses git for source control requiring windows users to install git for development work. The README_win32.pod file notes that msys git is one source but I have successfully installed git for Cygwin and used Cygwin git from the Windows cmd prompt to build parrot. As noted in README_win32.pod having the Msys/bin folder on the path confuses mingw32-make about the command shell by putting sh.exe on the path and putting the Cygwin bin directory on the path has the same problem. There is a more user friendly solution than requiring users to keep these bin directories off the path.

Adding the command
SHELL = cmd
to the makefile will tell mingw32-make to use the Windows cmd shell and the developer need no longer worry about the presence of sh.exe on their path.

The attached patch adds the "SHELL = cmd" line conditionally for win32 builds. While the patch has not been fully tested with the Visual C++ and nmake environment, it has been partially tested with nmake and nmake seems to quietly ignore the added line.

There is an older, related ticket for rakudo,  RT 78214.

Attachments

root.patch Download (448 bytes) - added by ronaldws 4 years ago.
Patch to add "SHELL = cmd" to the makefile for win32 builds

Change History

Changed 4 years ago by ronaldws

Patch to add "SHELL = cmd" to the makefile for win32 builds

Changed 4 years ago by jimmy

+1. Now I can build parrot without 'sh.exe' problem.

Changed 4 years ago by jimmy

  • status changed from new to closed
  • resolution set to fixed

applied in 51cfb3855ec91b184154639ccc74e03d5c07d380

Note: See TracTickets for help on using tickets.