Ticket #1902 (closed deprecation: done)

Opened 3 years ago

Last modified 3 years ago

Parrot_freeze_size should be removed for deprecation

Reported by: Matt221 Owned by: whiteknight
Priority: normal Milestone:
Component: none Version: master
Severity: medium Keywords:
Cc: whiteknight Language:
Patch status: Platform:

Description

After grep'ping the source tree, it looks like Parrot_freeze_size isn't called anywhere. After removing it, Parrot still compiles it and make test runs just fine.

Change History

  Changed 3 years ago by whiteknight

  • owner set to whiteknight
  • version changed from 2.10.0 to master
  • milestone set to 3.6

in reply to: ↑ description ; follow-up: ↓ 3   Changed 3 years ago by plobsing

Replying to Matt221:

After grep'ping the source tree, it looks like Parrot_freeze_size isn't called anywhere. After removing it, Parrot still compiles it and make test runs just fine.

This function was superceded by Parrot_freeze_pbc_size() for internal uses. It can (IMHO) be removed immediately. If it is felt this needs deprecation, immediate deprecation is in order, 3.6 milestone is too far in the future.

in reply to: ↑ 2   Changed 3 years ago by Matt221

Replying to plobsing:

Replying to Matt221:

After grep'ping the source tree, it looks like Parrot_freeze_size isn't called anywhere. After removing it, Parrot still compiles it and make test runs just fine.

This function was superceded by Parrot_freeze_pbc_size() for internal uses. It can (IMHO) be removed immediately. If it is felt this needs deprecation, immediate deprecation is in order, 3.6 milestone is too far in the future.

Here is the pull request:  https://github.com/parrot/parrot/pull/39

  Changed 3 years ago by dukeleto

  • status changed from new to closed
  • resolution set to done

Pull request merged in e8d5f3cbbd075c45a9808de1fc06aa591613da70

  Changed 3 years ago by jkeenan

  • milestone 3.6 deleted

Milestone 3.6 deleted

Note: See TracTickets for help on using tickets.