Ticket #1923 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Filehandle PMC clone VTABLE does not work

Reported by: Yuki`N Owned by: Yuki`N
Priority: normal Milestone:
Component: library Version: master
Severity: medium Keywords: gci
Cc: Matt221, whiteknight Language:
Patch status: new Platform: all

Description

(Discovered by Matt221)

Parrot's FileHandle PMC type defines a clone VTABLE, but the implementation looks to be quite buggy. The clone VTABLE creates a new FileHandle PMC and creates a raw copy of the OS handle object. It does not copy over any other details (I don't know if these would all be needed). This is probably very bad.

There is already a task created in Melange for fixing this. Making a formal trac ticket for this bug since the solution will likely need review.

Change History

Changed 4 years ago by Yuki`N

  • cc whiteknight added
  • status changed from new to assigned
  • patch set to new

Finished working up a tentative fix that lives in  a branch on my github.

This is subject to comments from others as well as test results as Matt develops more tests.

Changed 4 years ago by Yuki`N

Merged the branch  back to master on my fork after comments from whiteknight. Still waiting on tests.

Changed 4 years ago by Yuki`N

  • status changed from assigned to closed
  • resolution set to fixed

This was pulled  into master, closing this ticket.

Note: See TracTickets for help on using tickets.