Changes between Version 10 and Version 11 of Ticket #192

Show
Ignore:
Timestamp:
02/27/09 13:22:04 (5 years ago)
Author:
coke
Comment:

Generally, as soon as it's removed from the repository.

Deprecated.pod shows things that are still in but have been scheduled for eventual removal; once they are actually removed, there's no point to warn about their removal any more.

Even with the ticket still open for a few days, I'd still go ahead and remove it now.

Regards. (Whoops: used the wrong box to enter all my text last time, sorry.)

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #192 – description

    v10 v11  
    1 Generally, as soon as it's removed from the repository. 
     1The patch I just attached appears to satisfy the "before 1.0" deprecation requirement listed in DEPRECATED.pod. Parrot builds and passes all tests in make test. But since this is one of the few times I've ventured so far into Parrot's guts, so please note the following: 
    22 
    3 Deprecated.pod shows things that are still in but have been scheduled for eventual removal; once they are actually removed, there's no point to warn about their removal any more. 
     31. Basic approach was to grep the repository (fns . | xargs grep -in tqueue) and rip stuff out. Out went src/pmc/tqueue.pmc, t/pmc/tqueue.t and examples/pir/thr-primes.pir. Five tests were tossed out of t/pmc/threads.t and one test from t/op/gc.t. Ran makepmcrenumber to renumber PMCs. Updated MANIFEST. 
    44 
    5 Even with the ticket still open for a few days, I'd still go ahead and remove it now. 
     5Now, there may be some reason to take another look at the tests I ripped out, as those tests may be telling us something interesting about some other aspect of Parrot. On the other hand, if they were doing that, then they were not sufficiently focused tests to begin with. 
    66 
    7 Regards. 
     72. Files I didn't touch: 
     8a. docs/book/ch05_pasm.pod: example of threading and long discussion beginning around line 2317. Note that this discussion says that "in the previous chapter" -- presumably, chap04 -- it is stated that Parrot has three different threading models. I couldn't locate any discussion of threading in docs/book/ch04_pir_subroutines.pod. So this section of ch05 needs revision for reasons above and beyond the discussion of tqueue. 
     9 
     10b. languages/cardinal/src/classes/Queue.pir. See approx line 25. It appears that the Cardinal Queue class uses TQueue -- but I am not a Ruby programmer. 
     11 
     12The patch was developed in the deprecate_tqueue branch in SVN. Please review it carefully and let me know whether it's okay to merge into trunk. 
     13 
     14Thank you very much. 
     15kid51