Ticket #1937 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

t/src/embed.t - TODO passed: 3 in optimized builds

Reported by: mikehh Owned by:
Priority: normal Milestone:
Component: core Version: 2.11.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

test 3 of t/src/embed.t has a TODO pass with optimized builds

from prove -v t/src/embed.t (built with gcc-4.5 - NO --optimize)

not ok 3 - Minimal embed, create multiple interps without giving 1st interp to Parrot_new  # TODO TT #1880 : Parrot_new requires the 1st interp created as an argument
#   Failed (TODO) test 'Minimal embed, create multiple interps without giving 1st interp to Parrot_new '
#   at t/src/embed.t line 105.
# Exited with error code: [SIGNAL 6]
# Received:
# src/thread.c:1397: failed assertion '!interpreter_array'
# Backtrace - Obtained 10 stack frames (max trace depth is 32).
# /home/mhu/t.parrot/blib/lib/libparrot.so.2.11.0(+0xc08b2) [0xb753a8b2]
# /home/mhu/t.parrot/blib/lib/libparrot.so.2.11.0(Parrot_confess+0x9a) [0xb753a87a]
# /home/mhu/t.parrot/blib/lib/libparrot.so.2.11.0(+0x120e06) [0xb759ae06]
# /home/mhu/t.parrot/blib/lib/libparrot.so.2.11.0(+0x11879d) [0xb759279d]
# /home/mhu/t.parrot/blib/lib/libparrot.so.2.11.0(initialize_interpreter+0x2cb) [0xb7558dbb]
# /home/mhu/t.parrot/blib/lib/libparrot.so.2.11.0(make_interpreter+0x40) [0xb75589c0]
# /home/mhu/t.parrot/blib/lib/libparrot.so.2.11.0(Parrot_new+0x2c) [0xb7530dcc]
# ./t/src/embed_3(main+0x38) [0x804885b]
# /lib/libc.so.6(__libc_start_main+0xe7) [0xb6152ce7]
# ./t/src/embed_3() [0x8048761]
# 
# Expected:
# Done
# Really done
# 

the failed assertion - src/thread.c:1397: failed assertion '!interpreter_array' will not happen with an optimized build as --optimized builds ignore assertions.

Cheers, Michael (mikehh)

Change History

Changed 4 years ago by jkeenan

  • component changed from none to core

I confirmed this tonight. On the same linux/i386 box, when I configured without any --optimize this test remained a TODO FAIL. When I configured with --optimize=-O3, I got a TODO PASS.

Changed 4 years ago by nwellnhof

  • status changed from new to closed
  • resolution set to fixed

In d808617e14 I made this test fail in optimized builds by converting an assertion to an exception.

Note: See TracTickets for help on using tickets.