platform/generic/env.c incorrectly frees string passed to putenv()

[doughera]

Multiple tests in t/library/cgi_query_hash.t, t/op/gc.t, t/op/profiling/profiling.t, and t/pmc/env.t fail on a platform where putenv() is used because it frees the string envs out from under the system.

Failed Test                Stat Wstat Total Fail  List of Failed
-------------------------------------------------------------------------------
t/library/cgi_query_hash.t                7    5  3-7
t/op/gc.t                               139  101  11-111
t/pmc/env.t                              16    7  2-3 6 9 15-17
t/profiling/profiling.t       1   256    13   26  1-13

The attached patch fixes this and documents why the string isn't freed.

[doughera]

Don't free string passed to putenv().

[jkeenan]

Patch applied:

901764e | jkeenan++ | / (2 files): Merge branch 'doughera_3patches'. Applies patches submitted by doughera++ in TT #1950 and TT #1953.

Andy, please re-test.

Thank you very much.

kid51

[jkeenan]

Replying to jkeenan:

Patch applied: 901764e | jkeenan++ | / (2 files): Merge branch 'doughera_3patches'. Applies patches submitted by doughera++ in TT #1950 and TT #1953. Andy, please re-test.

Andy, do the patches applied work for you (both tickets)?

[doughera]

Replying to jkeenan:

Replying to jkeenan:

Patch applied: 901764e | jkeenan++ | / (2 files):

Andy, do the patches applied work for you (both tickets)?

This problem is solved. Closing ticket. (I'll separately post in #1950).