Can't compile with TRACE_PACKFILE set

[rgrjr]

I tried to compile pbc_merge with TRACE_PACKFILE in include/parrot/packfile.h defined as 1, and got the following compiler failure.

cc -I./include -I./include/pmc -D_REENTRANT -D_GNU_SOURCE -DDEBUGGING -pipe -fstack-protector -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHASATTRIBUTE_CONST -DHASATTRIBUTE_DEPRECATED -DHASATTRIBUTE_MALLOC -DHASATTRIBUTE_NONNULL -DHASATTRIBUTE_NORETURN -DHASATTRIBUTE_PURE -DHASATTRIBUTE_UNUSED -DHASATTRIBUTE_WARN_UNUSED_RESULT -DHASATTRIBUTE_HOT -DHASATTRIBUTE_COLD -DHAS_GETTEXT -g -fPIC -falign-functions=16 -funit-at-a-time -maccumulate-outgoing-args -W ... -fvisibility=hidden -Isrc/packfile -Isrc/ -o src/packfile/api.o -c src/packfile/api.c src/packfile/api.c: In function do_sub_pragmas : src/packfile/api.c:931:5: error: pf undeclared (first use in this function) src/packfile/api.c:931:5: note: each undeclared identifier is reported only once for each function it appears in src/packfile/api.c: In function PackFile_Header_unpack : src/packfile/api.c:1121:5: error: expected ; before if src/packfile/api.c:1122:5: error: pf undeclared (first use in this function) src/packfile/api.c: In function PackFile_unpack : src/packfile/api.c:1178:5: warning: cast discards qualifiers from pointer target type src/packfile/api.c:1178:5: warning: cast discards qualifiers from pointer target type make: *** [src/packfile/api.o] Error 1 rogers@rgr>

[plobsing]

The easiest solution would be to eliminate this flag. Such flags are of limited utility and often serve simply as a poor man's gdb.

That will be done immediately following the release (this bug does not merit code changes this close to a release). Until then, if it breaks when you do that, then don't do that!

[plobsing]

Eliminated in 7a4a752a402ed3501ab94773a48468eec512a2c8.

[doughera]

Replying to plobsing:

Eliminated in 7a4a752a402ed3501ab94773a48468eec512a2c8.

Hmm. Trac appears to have eaten my comment, where I noted that I have used this feature extensively in the past, and provided a patch to keep it compiling. (The patch is there, but the comment is missing.) In any case, I'd prefer to see it retained.