Ticket #1979 (closed bug: fixed)

Opened 4 years ago

Last modified 3 years ago

Configure.pl --without-extra-nci-thunks fails tests.

Reported by: coke Owned by: jkeenan
Priority: normal Milestone:
Component: testing Version: 3.0.0
Severity: medium Keywords: smolder
Cc: dukeleto, ligne Language:
Patch status: Platform:

Description

t/pmc/nci.t                               (Wstat: 16128 Tests: 73 Failed: 63)
  Failed tests:  5-15, 17-43, 45-59, 64-73
  Non-zero exit status: 63
t/src/checkdepend.t                       (Wstat: 256 Tests: 223 Failed: 1)
  Failed test:  97
  Non-zero exit status: 1
t/src/embed.t                             (Wstat: 512 Tests: 49 Failed: 2)
  Failed tests:  47-48
  Non-zero exit status: 2
t/library/pcre.t                          (Wstat: 256 Tests: 2 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=381, Tests=13698, 564 wallclock secs ( 4.06 usr  2.17 sys + 158.81 cusr 50.82 csys = 215.86 CPU)
Result: FAIL
make: *** [test_core] Error 1

This particular config flag is causing most of the current smoke.

Change History

Changed 4 years ago by jkeenan

On linux/i386, with libffi present, configured with --without-extra-nci-thunks, I got only one of the errors described above:

t/src/checkdepend.t                       (Wstat: 256 Tests: 224 Failed: 1)
  Failed test:  98
  Non-zero exit status: 1
Files=381, Tests=13851, 215 wallclock secs ( 1.59 usr  0.88 sys + 169.23 cusr 19.87 csys = 191.57 CPU)
Result: FAIL

See  Smolder 3802. commit de841c2f0a95f85c0ec51009283822a681662093

Changed 4 years ago by jkeenan

On darwin/ppc, with libffi and pcre NOT present, configured with --without-extra-nci-thunks, I got these failures:

Test Summary Report
-------------------
t/pmc/nci.t                               (Wstat: 16128 Tests: 73 Failed: 63)
  Failed tests:  5-15, 17-43, 45-59, 64-73
  Non-zero exit status: 63
t/src/checkdepend.t                       (Wstat: 256 Tests: 224 Failed: 1)
  Failed test:  98
  Non-zero exit status: 1
t/src/embed.t                             (Wstat: 512 Tests: 49 Failed: 2)
  Failed tests:  47-48
  Non-zero exit status: 2
Files=381, Tests=13891, 962 wallclock secs (12.85 usr  7.49 sys + 600.21 cusr 167.09 csys = 787.64 CPU)
Result: FAIL

Changed 3 years ago by jkeenan

The situation is unchanged on linux/i386 and darwin/ppc from what I reported four months ago.

Changed 3 years ago by jkeenan

  • cc ligne added

See also more recent ticket TT #2116, which configures Parrot in an even more stripped-down manner that includes --without-extra-nci-thunks.

kid51

Changed 3 years ago by jkeenan

In the tt2116_2117_1979 branch, where , on darwin/ppc, I configured as follows:

'configure_args' => '"--cc=/usr/bin/gcc" "--link=/usr/bin/g++" 
  "--ld=/usr/bin/g++" "--without-extra-nci-thunks" "--nomanicheck"',

This reduced the number of files failing to one:

$ prove -v t/src/checkdepend.t
t/src/checkdepend.t .. 
# couldn't find /usr/include/malloc.h, included from src/gc/malloc.c
# couldn't find extra_thunks.str, included from src/nci/extra_thunks.c

1..159
ok 1 - compilers/imcc/api.c (compilers/imcc/Rules.mak: line 5).
ok 2 - compilers/imcc/cfg.c (compilers/imcc/Rules.mak: line 114).
...
ok 81 - src/nci/core_thunks.c (Makefile: line 1733).
not ok 82 - src/nci/extra_thunks.c (Makefile: line 1745).

#   Failed test 'src/nci/extra_thunks.c (Makefile: line 1745).'
#   at t/src/checkdepend.t line 309.
#          got: 'src/nci/extra_thunks.str(1)
# '
#     expected: ''
ok 83 - src/nci/libffi.c (Makefile: line 1738).
...
# Looks like you failed 1 test of 159.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/159 subtests 

Test Summary Report
-------------------
t/src/checkdepend.t (Wstat: 256 Tests: 159 Failed: 1)
  Failed test:  82
  Non-zero exit status: 1
Files=1, Tests=159, 16 wallclock secs
  ( 0.33 usr  0.09 sys +  3.09 cusr  1.94 csys =  5.45 CPU)
Result: FAIL

So the patch improves the situation without completely resolving it.

Thank you very much.

kid51

Changed 3 years ago by ligne

that seems to be #2118 ("t/src/checkdepend.t fails when extra nci tthunks are disabled") rearing its head again.

Changed 3 years ago by jkeenan

  • status changed from new to assigned
  • owner set to jkeenan

See patch submitted in  TT 2118 comment 4 and commit 9f6220f.

Thank you very much.

kid51

Changed 3 years ago by jkeenan

I will close this ticket on or before Sun Jun 12 if there is no further objection.

Changed 3 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

No complaints received; closing as per plan.

Note: See TracTickets for help on using tickets.