Ticket #1983 (closed bug: fixed)

Opened 4 years ago

Last modified 3 years ago

Parrot_PMC_is_equal_num seems broken

Reported by: dukeleto Owned by: whiteknight
Priority: normal Milestone:
Component: embed/extend Version: 3.0.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform: all

Description

From t/src/extend_vtable.t :

not ok 38 - Parrot_PMC_is_equal_num # TODO seems borked
#   Failed (TODO) test 'Parrot_PMC_is_equal_num'
#   at t/src/extend_vtable.t line 75.
#          got: '1
# 0
# Done!
# '
#     expected: '0
# 1
# Done!
# '
# './t/src/extend_vtable_38' failed with exit code 0

where the test looks like :

extend_vtable_output_is(<<'CODE', <<'OUTPUT', "Parrot_PMC_is_equal_num", todo => 'seems borked' );
    Parrot_PMC_set_number_native(interp, pmc, -42);
    Parrot_PMC_set_number_native(interp, pmc2, 42);

    integer = Parrot_PMC_is_equal_num(interp, pmc, pmc2);
    printf("%d\n", (int) integer);

    Parrot_PMC_set_number_native(interp, pmc2, -42);

    integer = Parrot_PMC_is_equal_num(interp, pmc, pmc2);
    Parrot_printf(interp,"%d\n", integer);
CODE
0
1
Done!
OUTPUT


This seems backwards.

Change History

Changed 4 years ago by jkeenan

whiteknight,

It appears that dukeleto reworked this test in January of this year. The todo has been removed. Can you confirm that it works for you? If so, please close.

Thank you very much.

kid51

Changed 3 years ago by dukeleto

This has been fixed.

Changed 3 years ago by dukeleto

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.