Ticket #1984 (closed RFC: wontfix)

Opened 4 years ago

Last modified 3 years ago

Remove clone_pmc VTABLE slot

Reported by: cotto Owned by:
Priority: normal Milestone:
Component: core Version: 3.0.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

The clone_pmc VTABLE function is implemented only in the Class PMC and used only in the p_p_px variant of the clone op. The extent of its purpose is to create a clone of the Class, then initialize it with the contents of a PMC, which is assumed to be hash-like. Given this VTABLE slot's limited use, I'd like to deprecate it.

Change History

  Changed 4 years ago by bacek

+1

  Changed 3 years ago by jkeenan

  • component changed from none to core

cotto,

Are we actually going to deprecate it? If so, what is its replacement? Can we file a deprecation notice?

Thank you very much.

kid51

follow-up: ↓ 4   Changed 3 years ago by pmichaud

-2. Removing the clone_pmc vtable would seem to assume that all (HLL) PMCs types would have identical clone functionality, which I think to be unlikely in the long run.

(Just because Parrot's PMC types don't make much use of this vtable doesn't mean it won't be needed for more complex HLL types.)

Pm

in reply to: ↑ 3 ; follow-up: ↓ 5   Changed 3 years ago by jkeenan

Replying to pmichaud:

-2. Removing the clone_pmc vtable would seem to assume that all (HLL) PMCs types would have identical clone functionality, which I think to be unlikely in the long run.

cotto:

Do you accept pmichaud's reason for opposing this change?

If so, we can close this ticket.

Thank you very much.

kid51

in reply to: ↑ 4   Changed 3 years ago by cotto

  • status changed from new to closed
  • resolution set to wontfix

Replying to jkeenan:

Replying to pmichaud:

-2. Removing the clone_pmc vtable would seem to assume that all (HLL) PMCs types would have identical clone functionality, which I think to be unlikely in the long run.

cotto: Do you accept pmichaud's reason for opposing this change? If so, we can close this ticket. Thank you very much. kid51

Yup. I'll close this.

Note: See TracTickets for help on using tickets.