Ticket #1986 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

readline on Socket is broken

Reported by: fperrad Owned by: nwellnhof
Priority: normal Milestone:
Component: core Version: 3.0.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform: all

Description

the method readline of Socket PMC is broken

$ ./parrot examples/io/get.pir http://www.parrot.org/
** GET http://www.parrot.org/ ==> Null PMC access in get_string()
current instr.: 'parrot;HTTP;Response;status_line' pc 1149 (runtime/parrot/library/HTTP/Message.pir:558)
called from Sub 'parrot;LWP;UserAgent;progress' pc 936 (/home/user/checkout/parrot/runtime/parrot/library/LWP/UserAgent.pir:318)
called from Sub 'parrot;LWP;UserAgent;send_request' pc 262 (/home/user/checkout/parrot/runtime/parrot/library/LWP/UserAgent.pir:82)
called from Sub 'parrot;LWP;UserAgent;request' pc 406 (/home/user/checkout/parrot/runtime/parrot/library/LWP/UserAgent.pir:131)
called from Sub 'main' pc 38 (examples/io/get.pir:31)

the first readline on Socket PMC is in _receive_status_line (line 367 in file runtime/parrot/library/LWP/Protocol.pir) and returns empty data.

$ git bisect bad8bd0d93bc93520bd6b224cc72586ee1f4b0835b3 is the first bad commit
commit 8bd0d93bc93520bd6b224cc72586ee1f4b0835b3
Author: Nick Wellnhofer <wellnhofer@aevum.de>
Date:   Wed Jan 12 02:09:40 2011 +0100

    [io] Refactor platform socket API
$ git bisect log
git bisect start
# bad: [9b2a8993e86cac19ca09f9327580f27767ebc820] added missing codes after branch mergence
git bisect bad 9b2a8993e86cac19ca09f9327580f27767ebc820
# good: [07fbbcfb7dd7905fb03beb68cfcfb5989b8796ad] Merge branch 'exceptions_subclass'
git bisect good 07fbbcfb7dd7905fb03beb68cfcfb5989b8796ad
# bad: [74d0840267583dd0a28014c7dd21b395301fd443] [t] Unskip socket test on windows
git bisect bad 74d0840267583dd0a28014c7dd21b395301fd443
# good: [644658e93323546c38446b456cd66f557d9a9c56] Merge branch 'master' into nwellnhof/platform_src
git bisect good 644658e93323546c38446b456cd66f557d9a9c56
# bad: [83cc02b438aa135826e569a6b935a7664853c89a] Merge branch 'master' into nwellnhof/platform_src
git bisect bad 83cc02b438aa135826e569a6b935a7664853c89a
# bad: [97a37c99ce79612091e1ff3f3b7c3b979362a38a] Move process related code from io.c to exec.c
git bisect bad 97a37c99ce79612091e1ff3f3b7c3b979362a38a
# bad: [8bd0d93bc93520bd6b224cc72586ee1f4b0835b3] [io] Refactor platform socket API
git bisect bad 8bd0d93bc93520bd6b224cc72586ee1f4b0835b3

Change History

Changed 4 years ago by nwellnhof

  • status changed from new to assigned
  • owner set to nwellnhof

Changed 4 years ago by nwellnhof

This should be fixed in 2a4b6f959d.

Changed 4 years ago by fperrad

  • status changed from assigned to closed
  • resolution set to fixed

ok, on linux & Windows (RELEASE_3_0_0-180-ga224f7a)

Note: See TracTickets for help on using tickets.