Ticket #1987 (closed cage: fixed)

Opened 4 years ago

Last modified 4 years ago

Warnings from make headerizer

Reported by: mikehh Owned by: whiteknight
Priority: normal Milestone: 3.1
Component: tools Version: master
Severity: low Keywords: headerizer
Cc: whiteknight, plobsing Language:
Patch status: Platform: all

Description

After running make headerizer I get the following warnings:

...
Headerization complete.
src/exceptions.c
    Parrot_ex_build_complete_backtrace_string: Returns a pointer, but no PARROT_CAN(NOT)_RETURN_NULL macro found.
    Parrot_ex_build_complete_backtrace_string: Returns a pointer, but no PARROT_CAN(NOT)_RETURN_NULL macro found.
src/packfile/api.c
    Parrot_pf_create_default_segments: "ARGMOD(PackFile * const pf)" is const, but that ARGMOD conflicts with const
    Parrot_pf_get_current_code_segment: Returns a pointer, but no PARROT_CAN(NOT)_RETURN_NULL macro found.
    Parrot_pf_get_current_code_segment: Returns a pointer, but no PARROT_CAN(NOT)_RETURN_NULL macro found.
    Parrot_pf_get_current_packfile: Returns a pointer, but no PARROT_CAN(NOT)_RETURN_NULL macro found.
    Parrot_pf_get_current_packfile: Returns a pointer, but no PARROT_CAN(NOT)_RETURN_NULL macro found.
src/packfile/output.c
    update_backref_hash: "PackFile_ConstTable *ct" isn't protected with an ARGIN, ARGOUT or ARGMOD (or a _NULLOK variant), or ARGFREE
    update_backref_hash: "Hash *seen" isn't protected with an ARGIN, ARGOUT or ARGMOD (or a _NULLOK variant), or ARGFREE
src/pmc/imageiofreeze.pmc
    check_seen: "PMC *self" isn't protected with an ARGIN, ARGOUT or ARGMOD (or a _NULLOK variant), or ARGFREE
    check_seen: "PMC *v" isn't protected with an ARGIN, ARGOUT or ARGMOD (or a _NULLOK variant), or ARGFREE
src/pmc/imageiosize.pmc
    check_seen: "PMC *self" isn't protected with an ARGIN, ARGOUT or ARGMOD (or a _NULLOK variant), or ARGFREE
    check_seen: "PMC *v" isn't protected with an ARGIN, ARGOUT or ARGMOD (or a _NULLOK variant), or ARGFREE
13 warnings in 7 funcs in 5 C files

mhu@mhu-desktop:~/parrot$ date
Sun Jan 23 11:59:20 GMT 2011

It would be great if we could clear these up before the next release

Cheers Michael (mikehh)

Change History

  Changed 4 years ago by jkeenan

  • cc whiteknight, plobsing added

cc-ing people who recently worked in the affected areas of these files.

Andrew, Peter: Can you take a look?

Thank you very much.

kid51

  Changed 4 years ago by whiteknight

  • status changed from new to assigned
  • severity changed from medium to low
  • component changed from none to tools
  • platform set to all
  • version changed from 3.0.0 to master
  • keywords headerizer added
  • milestone set to 3.1
  • owner set to whiteknight
  • type changed from bug to cage

Some of these look like functions I'm responsible for. I'll take this ticket and get it resolved ASAP.

in reply to: ↑ description   Changed 4 years ago by plobsing

Replying to mikehh:

3 of the 5 offending files fixed in dff0be2.

  Changed 4 years ago by cotto

  • status changed from assigned to closed
  • resolution set to fixed

The remaining files are fixed in 2cb55d9.

Note: See TracTickets for help on using tickets.