Changes between Initial Version and Version 1 of Ticket #1991

Show
Ignore:
Timestamp:
01/29/11 17:07:39 (3 years ago)
Author:
jimmy
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1991 – description

    initial v1  
    22    I would like to simplify 'new_callback' op. first please see https://github.com/parrot/parrot/blob/master/t/pmc/nci.t#L1545-#L1606-1551. 
    33    there are lines: 
     4 
     5{{{ 
    46    .local pmc user_data 
    57    user_data = new ['Integer'] 
     
    2123    nci_cb_C1( cb_wrapped, user_data ) 
    2224 
     25}}} 
     26 
    2327 
    2428passing the value of user_data into new_callback is useless and unused, because it's finally invoked and used by this code. 
    2529nci_cb_C1( cb_wrapped, user_data ). So consider: 
     30 
     31{{{ 
    2632    .local pmc user_data 
    2733    user_data = new ['Integer'] 
     
    4450    nci_cb_C1( cb_wrapped, user_data ) 
    4551 
    46 so passing user_data = 42 to new_callback is redundant, I would simplify to this one: 
     52}}} 
     53 
     54so passing user_data = 42 to new_callback is redundant, I would simplify it to this one: 
     55 
     56{{{ 
    4757    cb_wrapped = new_callback cb, "vtU" 
     58}}} 
     59