Changes between Initial Version and Version 1 of Ticket #1991
- Timestamp:
- 01/29/11 17:07:39 (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #1991 – description
initial v1 2 2 I would like to simplify 'new_callback' op. first please see https://github.com/parrot/parrot/blob/master/t/pmc/nci.t#L1545-#L1606-1551. 3 3 there are lines: 4 5 {{{ 4 6 .local pmc user_data 5 7 user_data = new ['Integer'] … … 21 23 nci_cb_C1( cb_wrapped, user_data ) 22 24 25 }}} 26 23 27 24 28 passing the value of user_data into new_callback is useless and unused, because it's finally invoked and used by this code. 25 29 nci_cb_C1( cb_wrapped, user_data ). So consider: 30 31 {{{ 26 32 .local pmc user_data 27 33 user_data = new ['Integer'] … … 44 50 nci_cb_C1( cb_wrapped, user_data ) 45 51 46 so passing user_data = 42 to new_callback is redundant, I would simplify to this one: 52 }}} 53 54 so passing user_data = 42 to new_callback is redundant, I would simplify it to this one: 55 56 {{{ 47 57 cb_wrapped = new_callback cb, "vtU" 58 }}} 59