Ticket #2009 (closed cage: fixed)

Opened 3 years ago

Last modified 3 years ago

Remove dead svn-related code from Perl modules

Reported by: dukeleto Owned by: jkeenan
Priority: normal Milestone:
Component: configure Version: 3.0.0
Severity: medium Keywords:
Cc: mikehh Language:
Patch status: applied Platform: all

Description

An ack -ai svn lib shows lots of code that is not used. This ticket is to remove all svn-related dead Perl code and update the relevant documentation.

Attachments

remove_more_svn_references.diff Download (3.1 KB) - added by jkeenan 3 years ago.
Remove or correct 'svn' references in 4 files

Change History

  Changed 3 years ago by jkeenan

  • status changed from new to assigned

I list here various cases where it's not 100% clear what should replace instances of svn or subversion in the codebase:

examples/languages/squaak/doc/tutorial_episode_1.pod

274 =item * Perl 6/NQP rules syntax: Synopsis 5 at http://perlcabal.org/syn/S05.html 
or http://svn.pugscode.org/pugs/docs/Perl6/Spec/S05-regex.pod
# pugscode.org link is dead

follow-up: ↓ 6   Changed 3 years ago by jkeenan

I've picked some of the low-hanging fruit, but we'll probably have to consult on appropriate replacements for instances of 'svn' or 'subversion' in files like these:

lib/Parrot/IO/File.pm
MANIFEST.SKIP
lib/Parrot/Manifest.pm
lib/Parrot/Revision.pm
runtime/parrot/library/distutils.pir
tools/dev/create_language.pl
tools/dev/fetch_languages.pl
tools/dev/mk_language_shell.in

Changed 3 years ago by jkeenan

Remove or correct 'svn' references in 4 files

  Changed 3 years ago by jkeenan

  • cc mikehh added

I have attached a patch which addresses some of the remaining references to svn, et. all., in these files:

MANIFEST.SKIP
lib/Parrot/Manifest.pm
lib/Parrot/Revision.pm

... and also the references to tools/dev/mk_manifest_and_skip.pl in:

MANIFEST
MANIFEST.SKIP

I don't claim that the replacement language is the best possible, but I do think it constitutes an improvement over the current language.

mikehh, dukeleto: If you agree, then we should apply this patch before the release.

Thank you very much.

kid51

  Changed 3 years ago by jkeenan

See also TT #1491 and TT #2003.

  Changed 3 years ago by mikehh

committed patch (with a couple of mods) in d4309a5

also removed $Id$ line in MANIFEST/MANIFEST.SKIP and the generation of that

I think that line 59 of the new lib/Parrot/Manifest.pm can also be removed

Cheers Michael (mikehh)

in reply to: ↑ 2   Changed 3 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed
  • patch set to applied

Replying to jkeenan: I have handled all relevant instances of svn and subversion with the exception of the following:

tools/dev/create_language.pl
tools/dev/mk_language_shell.in

We have a longstanding issue about these two programs, as documented in the other Trac tickets cited in comment 4 above. I vote to defer removal of svn from them until we decide how to resolve that issue.

runtime/parrot/library/distutils.pir
tools/dev/fetch_languages.pl

These are programs that face outward to other projects' repositories, which may use Subversion. So they should not change.

Closing this ticket.

kid51

Note: See TracTickets for help on using tickets.