Ticket #2011 (closed todo: fixed)

Opened 4 years ago

Last modified 4 years ago

Replace MMD_cache with Hash PMC.

Reported by: bacek Owned by:
Priority: major Milestone: 3.1
Component: core Version: master
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

Hello.

Currently MMD_Cache is typdefed to hash, not Hash PMC. Which causes few problems with GenGC (at least) and requires additional work from HLLs (at least Rakudo) to handle it. Replacing MMD_Cache with Hash PMC will solve most of the problems.

-- Bacek

Change History

Changed 4 years ago by whiteknight

What are the performance implications? I don't think it should be large but there could be some surprises.

Assuming nothing bad happens, it's +1 from me.

Changed 4 years ago by bacek

Hello.

No, it shouldn't have any performance implications.

-- Bacek

Changed 4 years ago by cotto

I'm working on this in the mmd-cache-pmc branch and so far it seems to be a pretty straightforward change. Only a checkdepends test fails after the change. I'll test Rakudo and Partcl (!) and will merge if they look good.

Changed 4 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

Rakudo's spectest passes (apart from a single test that moritz says is goofy) and Partcl looks fine. The branch was merged in ecc49a6, so I'm marking this ticket as fixed.

Note: See TracTickets for help on using tickets.