Ticket #2092 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

config/auto/llvm.pm: Offer explicit optout

Reported by: jkeenan Owned by: jkeenan
Priority: normal Milestone:
Component: configure Version: 3.2.0
Severity: medium Keywords:
Cc: bacek, whiteknight Language:
Patch status: new Platform:

Description

As recommended by plobsing in TT #2089:

I'd also like to see an  an explicit Configure.pl option 
to opt-out of LLVM, similar to what we do for other 
external libraries (eg: --without-libffi, --without-pcre, 
etc...). 

I will try to get to this.

Attachments

llvm_optin.985e82a5873.diff Download (3.9 KB) - added by jkeenan 4 years ago.
Introduce --with-llvm option to explicitly link to LLVM

Change History

Changed 4 years ago by bacek

Hello.

Just my $.02 - I think opt-in for llvm would be better. E.g. "don't probe for llvm if --with-llvm-config wasn't passed to Configure.pl".

-- Bacek

Changed 4 years ago by jkeenan

  • status changed from new to assigned

Any other opinions as to how we should proceed? (I'll go with bacek's suggestion unless counterindicated).

kid51

Changed 4 years ago by jkeenan

  • patch set to new

This work has been done in the llvm_optin branch.

 Smolder report 14609

See diff attached. Please review.

Thank you very much.

kid51

Changed 4 years ago by jkeenan

Introduce --with-llvm option to explicitly link to LLVM

Changed 4 years ago by jkeenan

  • cc bacek, whiteknight added

Comments? Can this go in before 3.3?

kid51

Changed 4 years ago by cotto

  • status changed from assigned to closed
  • resolution set to fixed

Whiteknight said we're not frozen, so I committed it as 370a41843c. Thanks!

Note: See TracTickets for help on using tickets.