Ticket #2095 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

t/op/spawn.t: failure due to Perl 5 problem

Reported by: jkeenan Owned by:
Priority: normal Milestone:
Component: testing Version: 3.2.0
Severity: medium Keywords:
Cc: whiteknight Language:
Patch status: new Platform:

Description

On a linux/i386 box to which I have some access, I try to test Parrot as much as possible. On this box, the system Perl is 5.10.0 (some level of Ubuntu) but I use 5.12.0 compiled from source.

I've recently noticed this failure during make test (configured with no options):

t/op/spawnw...............Perl lib version (5.10.0) doesn't 
  match executable version (v5.12.0) at 
  /usr/lib/perl/5.10/Config.pm line 46.
Compilation failed in require.
BEGIN failed--compilation aborted.
^Cmake: *** [op_tests] Interrupt

And at this point, make test stops dead.

For reasons I cannot fathom, this test plays around with env. When I remove this nonsense, t/op/spawnw.t PASSes completely.

diff --git a/t/op/spawnw.t b/t/op/spawnw.t
index bb48be1..82a4d0b 100644
--- a/t/op/spawnw.t
+++ b/t/op/spawnw.t
@@ -45,15 +45,7 @@ Nigel Sandever - L<nigelsandever@btconnect.com>
 
 # test string version of spawnw
 
-
-my $perl = "perl";
-my $perl_exists = `perl -V`;
-unless ($perl_exists) {
-    if( -e "/usr/bin/env" ) {
-        $perl = system("/usr/bin/env perl");
-    }
-}
-
+my $perl = $^X;
 
 pasm_output_is( <<"CODE", <<'OUTPUT', "exit code: 0" );
 .pcc_sub :main main:

Would anyone object to my applying this patch before 3.3?

Thank you very much.

kid51

Attachments

t.op.spawnw.t.diff Download (481 bytes) - added by jkeenan 4 years ago.
Eliminate us of 'env'

Change History

Changed 4 years ago by jkeenan

Eliminate us of 'env'

Changed 4 years ago by jkeenan

  • cc whiteknight added

Comments? Can this go in before 3.3?

Thank you very much.

kid51

Changed 4 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

It can go in and it did, as 73edd4957. Thank you for the fix.

Note: See TracTickets for help on using tickets.