string_repeat siganture, maybe bug

[NotFound]

The string_repeat functions in string.c has a parameter d that seems to be passed NULL in all usages in the repository. The pod doc says that the string is created "if necessary" but that is not what the code does, it always create a new STRING object. Finally, if the num of repetitions is 0 it does not update *d. As long as there is no non-null usage, there is no way to fix and test the documented semantic.

I suggest to drop the d parameter. pdd28 says that it must be renamed as Parrot_string_repeat, we can create now and start replacing the usages in the repo.

[NotFound]

Accepted in #ps with the new name Parrot_str_repeat. Working on it.

[NotFound]

Done in r36065, waiting for comments

[barney]

Looks fine. Could you also removed the old function 'string_repeat'?

[NotFound]

I think this function was public enough to require a deprecation cycle. We can deprecate it now, or just let it to the strings pdd.

[coke]

Deprecation should happen asap. Added note to pod file.

[coke]

This was removed in r36271, despite the fact that we advertised it as removed post 0.9.1

Resolving ticket, removing item from DEPRECATED.pod