Ticket #2106 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

git_describe configuration value not correct

Reported by: pmichaud Owned by: cotto
Priority: normal Milestone:
Component: configure Version: 3.3.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description (last modified by pmichaud) (diff)

After performing "git pull" and receiving new commits and running "make", the value of "git_describe" reported by parrot_config and "parrot --version" is incorrect. A re-run of Configure.pl is needed to bring the values up to date.

Rakudo solves this problem by calculating the git-describe value at the time Rakudo is built. The larger source has a static .include "src/gen/version.pir" -- the Makefile then generates src/gen/version.pir to contain

    .macro_const RAKUDO_VERSION "<git-describe-value>"
    .macro_const RAKUDO_BUILD_DATE "<rakudo-build-date>"

Hope this helps.

Pm

Change History

Changed 4 years ago by pmichaud

  • description modified (diff)

Changed 4 years ago by coke

See also TT #1884

Changed 4 years ago by cotto

I've started working on this in the  compiletime-git-describe branch. The aim is that any time config_lib.pir is rebuilt, it'll be built with a current sha1 and git-describe. My only uncertainty is about Parrot::Git::Describe and Parrot:SHA1's caching and whether deleting their cache files is the best way to ensure that parrot_version.pir will always be up-to-date.

Changed 4 years ago by cotto

After verifying with dukeleto that in the common case, the build doesn't benefit from Parrot::Git::Describe and Parrot:SHA1's caching, I removed it. At this point I'm fairly confident that the branch does what we want it to. As always review is appreciated, but I plan on merging this weekend unless someone gives me a good reason not to.

Changed 4 years ago by jkeenan

  • owner set to cotto
  • component changed from none to configure

Changed 4 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

The branch has been merged and I've verified that it dtrt. I'm marking this ticket as fixed. Thanks for reporting!

Note: See TracTickets for help on using tickets.