Ticket #2132 (closed todo: fixed)

Opened 4 years ago

Last modified 4 years ago

NQP-rx does not use "file" annotations

Reported by: whiteknight Owned by: benabik
Priority: normal Milestone:
Component: nqp Version: master
Severity: medium Keywords: nqp-rx
Cc: Language: perl6
Patch status: new Platform: all

Description

PIR code generated from the NQP-rx compiler do not contain "file" annotations. It does contain "line" annotations, but those aren't enough if you have a project spanning multiple files or multiple dynamically-loaded bytecode libraries.

Attachments

0001-pct-Add-file-annotations-to-generated-PIR.patch Download (1.0 KB) - added by benabik 4 years ago.
File Annotations

Change History

Changed 4 years ago by benabik

  • owner changed from pmichaud to benabik

This is a deeper problem than just nqp-rx. PCT::HLLCompiler stores the file names in a variable $?FILES but that variable is only used to generate errors about undeclared variables. The simple fix is probably to just add a file annotation to the top of the POST tree based on $?FILES.

Changed 4 years ago by benabik

File Annotations

Changed 4 years ago by benabik

  • status changed from new to closed
  • resolution set to fixed
  • patch set to new

Fixed in 6afb0ae02319c56080dec9ffb902f02471331595

Note: See TracTickets for help on using tickets.