Ticket #2134 (closed todo: done)

Opened 11 years ago

Last modified 10 years ago

Move src/pbc_disassemble.c to frontend/pbc_disassemble/main.c

Reported by: whiteknight Owned by: soh_cah_toa
Priority: normal Milestone:
Component: embed/extend Version: master
Severity: medium Keywords:
Cc: Language:
Patch status: Platform: all

Description

This is a front-end file. Move it to the frontend/ folder. Update it to use the embedding API.

Also, there is a Parrot_disassemble function in src/embed.c. We should either move that function into a file which is more oriented towards disassembly.

Attachments

tt2134.patch Download (16.2 KB) - added by soh_cah_toa 11 years ago.

Change History

  Changed 11 years ago by soh_cah_toa

I think it already uses the embedding API. I see plenty of Parrot_api_* calls and other API features being used. It doesn't explicitly #include parrot/api.h in the file. However, it does list it as a dependency in the Makefile which is...well...dumb.

I think I can take this on. This file could stand to be cleaned up a bit as well. I'll wait for your response before doing anything though.

  Changed 11 years ago by soh_cah_toa

  • status changed from new to assigned
  • owner changed from whiteknight to soh_cah_toa

Changed 11 years ago by soh_cah_toa

  Changed 11 years ago by soh_cah_toa

Patch applied in commit 7684807f56e44ed6c3a4.

 https://github.com/parrot/parrot/commit/7684807f56

follow-up: ↓ 5   Changed 11 years ago by soh_cah_toa

I would like to hold off on moving Parrot_disassemble() since it relies on parrot_debugger. I can re-write it to do the same thing HBDB-style and move it at the same time all in one separate ticket.

How do you feel about that?

in reply to: ↑ 4   Changed 10 years ago by jkeenan

Replying to soh_cah_toa:

I would like to hold off on moving Parrot_disassemble() since it relies on parrot_debugger. I can re-write it to do the same thing HBDB-style and move it at the same time all in one separate ticket.

Can we get an update on the status of this ticket?

Thank you very much.

kid51

  Changed 10 years ago by benabik

  • status changed from assigned to closed
  • resolution set to done

src/pbc_disassemble.c was moved to frontend/pbc_disassemble/main.c in 7684807. Parrot_disassemble() was moved to src/disassemble.c in 796e991.

I'm going to call this one done.

Note: See TracTickets for help on using tickets.