Ticket #2140 (closed deprecation: fixed)

Opened 3 years ago

Last modified 3 years ago

Deprecate all PackFile_* functions

Reported by: whiteknight Owned by: whiteknight
Priority: normal Milestone:
Component: core Version: master
Severity: medium Keywords:
Cc: Language:
Patch status: Platform: all

Description

Several functions in src/packfile/*.c are being marked with PARROT_EXPORT and they should not be. Many of these functions are internal-only routines and shouldn't be exposed directly.

All functions named "PackFile_*" should be deprecated. They are being replaced by a new set of API functions named "Parrot_pf_*", per conventions.

Change History

Changed 3 years ago by jkeenan

  • component changed from none to core

Changed 3 years ago by cotto

+1

Changed 3 years ago by whiteknight

  • status changed from new to assigned
  • owner set to whiteknight

Cotto gave the greenlight for this ticket. I'm going to add the notice to api.yaml. I'll be posting upgrade docs when we've got more of the new interface implemented.

Changed 3 years ago by whiteknight

  • platform set to all
  • version changed from 3.5.0 to master

I've cleaned up several API functions in the whiteknight/pbc_pbc branch, which recently merged to master. There are now properly-named replacements for most (not all) of the externally-used API functions from the packfile subsystem. I've included comments throughout src/packfile/api.c to indicate the intended upgrade paths for most of the remaining deprecated functions.

There are a few stragglers, like PackFile_fixup_subs which are not going to be replaced directly. I am still working to find replacements for these cases. They will probably tracked in other tickets.

Changed 3 years ago by whiteknight

  • status changed from assigned to closed
  • resolution set to fixed

We've done the lion's share of work on this ticket. All remaining instances of "PackFile_*" functions are not renamed because of larger issues which can be addressed in different tickets. I'm closing this one.

Note: See TracTickets for help on using tickets.