Ticket #2161 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Whitespace confusion in PCT docs

Reported by: whiteknight Owned by: jkeenan
Priority: normal Milestone:
Component: docs Version: master
Severity: low Keywords: docs pct
Cc: Language:
Patch status: applied Platform: all

Description

From writtencode on IRC:

Hey guys, just want to point out something in the docs about the grammar
 (http://docs.parrot.org/parrot/latest/html/docs/book/pct/ch04_pge.pod.html)
- Under "Rules and Tokens", there's the line "The record rule given previously
would match "6355 John" or "6355 John" but not "6355John"." The two examples
of what would work appear to be exactly the same; I assume there's supposed
to be an endline or extra space, but there ddoesn't
It's about smart whitespace matching, so it probably just needs blatant
extra whitespace characters

Change History

  Changed 3 years ago by jkeenan

  • owner set to jkeenan
  • status changed from new to assigned
  • patch set to applied

I applied what I hope will be a fix in commit c3f359c49180. You can see the effect, albeit without CSS,  here.

I'll keep this open until 3.7 is out and we can see how it looks with full CSS on parrot.org.

Thank you very much.

kid51

follow-up: ↓ 3   Changed 3 years ago by coke

Or we could just run "make html" locally and look at the result; let's do that so we don't have to wait until the next release if it's not what you wanted.

in reply to: ↑ 2   Changed 3 years ago by jkeenan

Replying to coke:

Or we could just run "make html" locally and look at the result;

I did run make html on my own box; that's what the link I provided points to. It doesn't show up with all the CSS goodness, but does seem to indicate that better whitespace will be displayed. I just want to hold the ticket open until I can see it on docs.parrot.org.

Thank you very much.

kid51

  Changed 3 years ago by coke

On Fri, Aug 12, 2011 at 4:08 PM, Parrot <parrot-tickets@lists.parrot.org> wrote:
> #2161: Whitespace confusion in PCT docs
> -------------------------+--------------------------------------------------
>  Reporter:  whiteknight  |       Owner:  jkeenan
>     Type:  bug          |      Status:  assigned
>  Priority:  normal       |   Milestone:
> Component:  docs         |     Version:  master
>  Severity:  low          |    Keywords:  docs pct
>     Lang:               |       Patch:  applied
>  Platform:  all          |
> -------------------------+--------------------------------------------------
>
> Comment(by jkeenan):
>
>  Replying to [comment:2 coke]:
>  > Or we could just run "make html" locally and look at the result;
>
>  I did run `make html` on my own box; that's what the link I provided
>  points to.  It doesn't show up with all the CSS goodness, but does seem to
>  indicate that better whitespace will be displayed.  I just want to hold
>  the ticket open until I can see it on docs.parrot.org.

All the CSS on docs.parrot.org is copied there from a local "make html" run.

Note:

http://docs.parrot.org/parrot/latest/html/

that refers to the style sheet: "../resources/parrot.css"

so, that's:

http://docs.parrot.org/parrot/latest/resources/parrot.css

... and we copied both the html and the resources directories there
from a parrot build directory that someone typed "make html" in - both
of those directories exist locally, and are in the correct position
relative to each other.

So, when I run "make html" locally,and open up
$BUILD/docs/html/index.html. e.g. on windows:

> nmake html
> start docs\html\index.html

.. .fires up IE, and I see the local copy with the same styles as I do
when I visit the website.

So if you're not seeing the styles, there's an issue somewhere locally.

Most browsers have a dev tool that will show you what resources are
being loaded that are not being found.

>  Thank you very much.
>
>  kid51



-- 
Will "Coke" Coleda

  Changed 3 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

Visually confirmed that problem is fixed  here. Closing ticket.

Note: See TracTickets for help on using tickets.