Ticket #217 (closed patch: fixed)

Opened 6 years ago

Last modified 5 years ago

fix badly named variable in generated code

Reported by: coke Owned by:
Priority: normal Milestone:
Component: core Version:
Severity: low Keywords:
Cc: Language:
Patch status: applied Platform:

Description (last modified by jkeenan) (diff)

The id here isn't tracking the id of the pmc, but of the HLL.

--- lib/Parrot/Pmc2c/PMCEmitter.pm      (revision 35922)
+++ lib/Parrot/Pmc2c/PMCEmitter.pm      (working copy)
@@ -683,13 +683,13 @@

         {
             /* Register this PMC as a HLL mapping */
-            const INTVAL pmc_id = Parrot_get_HLL_id( interp, CONST_STRING_GEN(interp, "$hll")
+            const INTVAL hll_id = Parrot_get_HLL_id( interp, CONST_STRING_GEN(interp, "$hll")
             );
-            if (pmc_id > 0) {
+            if (hll_id > 0) {
 EOC
         foreach my $maps ( sort keys %{ $self->{flags}{maps} } ) {
             $cout .= <<"EOC";
-                Parrot_register_HLL_type( interp, pmc_id, enum_class_$maps, entry);
+                Parrot_register_HLL_type( interp, hll_id, enum_class_$maps, entry);
 EOC
         }
         $cout .= <<"EOC";

Change History

Changed 5 years ago by jkeenan

  • component changed from none to core
  • description modified (diff)

Changed 5 years ago by NotFound

  • status changed from new to closed
  • resolution set to fixed
  • patch set to applied

Applied, and failed test changed accordingly, in r40308.

Note: See TracTickets for help on using tickets.