Ticket #2170 (closed feature: done)

Opened 3 years ago

Last modified 3 years ago

as_string method to get strings from NCI results

Reported by: NotFound Owned by: NotFound
Priority: normal Milestone: 3.7
Component: core Version: 3.6.0
Severity: medium Keywords: nci encoding
Cc: Language:
Patch status: Platform:

Description

After discusssion at #parrotsketch we've decided to add the method as_string to UnManagedStruct now, with the intention to add it also to its replacement before UnManagedStruct ends its deprecation cycle.

I've created the branch NotFound/nci_as_string to work in the first step. This ticket is to track the progress ot that branch until its eventual merge.

Attachments

mysql_as_string.patch Download (5.6 KB) - added by NotFound 3 years ago.

Change History

Changed 3 years ago by NotFound

  Changed 3 years ago by NotFound

I've added the as_string method also to the Ptr PMC, it's needed to work with char * in structs the same way as in returned values. I think Ptr will be the appropriate replacement for UnManagedStruct in that role.

I've made specifying the encoding optional, defaulting to the platform encoding. I'm not sure about that default, maybe binary will be safer.

The attached file shows the impact of using ByteBuffer and the as_string method in the winxed Mysql example.

  Changed 3 years ago by NotFound

Update the branch to current master by merging into a new branch NotFound/nci_as_string_ready

Deleted the initial branch.

Merged NotFound/nci_as_string_ready into master

When changes get well tested and reviewed, the last branch will be deleted and this ticket closed.

follow-up: ↓ 4   Changed 3 years ago by jkeenan

  • component changed from none to core

I corrected one codingstd error in NotFound/nci_as_string_ready branch. There are others remaining in src/pmc/packfileview.pmc.

in reply to: ↑ 3   Changed 3 years ago by jkeenan

Replying to jkeenan:

There are others remaining in src/pmc/packfileview.pmc.

Hmm, they exist in master as well. I'll try to fix them there.

kid51

  Changed 3 years ago by NotFound

Branch deleted. Closing ticket.

  Changed 3 years ago by NotFound

  • status changed from new to closed
  • resolution set to done
Note: See TracTickets for help on using tickets.