Bug in setup-parrot-3.6.0.exe broke PATH

["mzoppet@…>]

Dear team,

I downloaded for my first time a Parrot setup for Windows, and tested it on my Windows 7 environment.
After the installation I had a lot of problems because I lost the capacity to run quite every command.

I discovered that the installer changed the type of the PATH environment variable stored in the registry. Since NT 3.1 this key value must be of type "REG_EXPAND_SZ".

I retrieved the source and the broken file should be "\tools\dev\mk_inno.pl" at line 89, where it is used:

   ValueType: string;

instead of 

   ValueType: expandsz;

This setting is OS version dependent. If your target is to support only Windows versions officially supported by Microsoft (currently XP SP3 or newer) simply change the ValueType to "expandsz". Otherwise you must do some deep checks on the OS version in use at installation time.

Best regards,
Mario Zoppetti

http://support.microsoft.com/kb/102985

http://www.jrsoftware.org/ishelp/index.php?topic=registrysection

How do I modify the PATH environment variable when running an Inno Setup Installer?
http://stackoverflow.com/questions/3304463/how-do-i-modify-the-path-environment-variable-when-running-an-inno-setup-installe

 

untitled-part.html

[mzoppet@…]

Added by email2trac

[mzoppet@…]

This message has 1 attachment(s)

[fperrad]

setup-parrot-3.7.0.exe was shipped with this fix.

could you test it ?

[jkeenan]

The original poster sent an email to parrot-tickets, which would have required moderator approval and which would not, in any event, have made it into Trac. So I am posting the content of the email here in Trac. And since it appears the problem is resolved, I'm closing the ticket as well. -- kid51

Dear team,

I confirm that for my PC using setup-parrot-3.7.0 the problem is fixed.

Many thanks for the VERY quick fix!

Best regards, Mario Zoppetti

[fperrad]

fixed in  https://github.com/parrot/parrot/commit/a136a32840f6ee41efc9d4f2b932487d91318887