Ticket #2189 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

t/library/yaml_tiny.t: new test failure

Reported by: jkeenan Owned by:
Priority: normal Milestone:
Component: library Version: 3.7.0
Severity: medium Keywords:
Cc: plobsing Language:
Patch status: Platform:

Description

A new failure has emerged in this file within the past 24 hours:

 $ prove -v t/library/yaml_tiny.t 
t/library/yaml_tiny.t .. 
ok 1 - empty
...
ok 28 - empty_comment_in_list
ok 29 - empty_comment_in_hash
not ok 30 - failed to parse api.yaml
1..30
Failed 1/30 subtests 

Test Summary Report
-------------------
t/library/yaml_tiny.t (Wstat: 0 Tests: 30 Failed: 1)
  Failed test:  30
Files=1, Tests=30,  8 wallclock secs 
  ( 0.03 usr  0.01 sys +  8.04 cusr  0.02 csys =  8.10 CPU)
Result: FAIL

Change History

Changed 3 years ago by jkeenan

  • cc plobsing added

Changed 3 years ago by jkeenan

Bisecting api.yaml, the test failure emerges around line 551:

548 -
549   name : '"constant" PObj'
550   eligible : '3.1'
551   note : |
552     "constant" PObj (which is never collected) are deprecated. All PMCs and STRINGs
553     should be properly marked during GC.
554 
555     Functions C<Parrot_pmc_new_constant>, C<Parrot_pmc_new_constant_noinit>,
556     C<Parrot_pmc_new_constant_init> and C<Parrot_pmc_new_constant_init_int>
557     will be removed.
558 
559     PObj flag C<PObj_constant_FLAG> and related macros will be removed.
560   ticket : 'https://trac.parrot.org/parrot/ticket/1875'

When line 550 is the last line of the file, the test passes. Once I add the block starting at line 551, the test fails.

Changed 3 years ago by jkeenan

I have little previous experience with YAML, but eliminating the pipes following several instances of note: appears to get t/library/yaml_tiny.t passing once again:

$ git diff -- ./api.yaml |cat
diff --git a/api.yaml b/api.yaml
index 318d1de..62e1637 100644
--- a/api.yaml
+++ b/api.yaml
@@ -548,7 +548,7 @@
 -
   name : '"constant" PObj'
   eligible : '3.1'
-  note : |
+  note :
     "constant" PObj (which is never collected) are deprecated. All PMCs and STRINGs
     should be properly marked during GC.
 
@@ -561,7 +561,7 @@
 -
   name : 'Non-const STRING* arguments'
   eligible : '3.1'
-  note : |
+  note :
     Due immutable nature of STRINGs we are changing internal handling to use only
     const STRING pointers. It will improve optimizations possibilities by compiler,
     make parrot const-correct, etc.
@@ -578,7 +578,7 @@
 -
   name : 'The PIR and PASM compreg PMCs'
   eligible : '3.1'
-  note : |
+  note :
     The PMC returned by C<compreg "PIR"> is not going to be an NCI PMC any longer,
     it will be a new type of PMC which conforms to PDD31 and will be similar to
     HLLCompiler.
@@ -586,3 +586,4 @@
     There will not be a PASM compreg anymore.
   ticket : 'http://trac.parrot.org/parrot/ticket/1967'
 
+

Someone more knowledgeable than I should evaluate that diff and apply it if it's correct.

Thank you very much.

kid51

Changed 3 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

committed in 8b78a4f

Note: See TracTickets for help on using tickets.