Ticket #222 (closed bug: fixed)

Opened 6 years ago

Last modified 5 years ago

Test failure in t/perl/Parrot_Docs.t

Reported by: mikehh Owned by: jkeenan
Priority: normal Milestone:
Component: none Version: trunk
Severity: medium Keywords:
Cc: Language:
Patch status: new Platform: all

Description

The Test t/perl/Parrot+Docs.t fails (as at revision 35953) as follows:

ok 1 - use Parrot::Docs::POD2HTML;
...
ok 15 - num_pod_errors none

not ok 16 - pod_as_html
# Failed test 'pod_as_html'
# at t/perl/Parrot_Docs.t line 63.
# '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
# " http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
# <html xmlns=" http://www.w3.org/1999/xhtml">
....... ---- fails here
# <head>
...
...
# </body>
# </html>
# '
# doesn't match '(?si-xm:<html>.*?</html>)'

ok 17 - contains_pod yes, errors
...
ok 25 - write_html
looks like you failed 1 test of 25.


The test should be be '<html.*?</html>' dropping the '>' as the above is valid.

Patch included

Cheers,

Michael

Attachments

perl_Parrot_Docs_t.patch Download (0.6 KB) - added by mikehh 6 years ago.
fix test for valid html (revision 35953)

Change History

Changed 6 years ago by mikehh

fix test for valid html (revision 35953)

  Changed 6 years ago by mikehh

It is possible that you might want to test that the opening html tag is closed using something like '<html[>]*>.*?</html>'

Cheers,

Michael

  Changed 6 years ago by mikehh

oops the superscripted the expression

try '<html[!>]*>.*?</html>' with ! replaced by

must learn to use preview before submitting

Cheers,

Michael

  Changed 6 years ago by mikehh

well preview doesn't work properly either

try '<html[!>]*>.*?</html>' with ! replaced by <carat> -> <shift> & 6

ah well

Cheers,

Michael

in reply to: ↑ description   Changed 6 years ago by jkeenan

Replying to mikehh:

The Test t/perl/Parrot+Docs.t fails (as at revision 35953) as follows: ok 1 - use Parrot::Docs::POD2HTML;
...
ok 15 - num_pod_errors none not ok 16 - pod_as_html
# Failed test 'pod_as_html'
# at t/perl/Parrot_Docs.t line 63.
# '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
# " http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
# <html xmlns=" http://www.w3.org/1999/xhtml">
....... ---- fails here
# <head>
...
...
# </body>
# </html>
# '
# doesn't match '(?si-xm:<html>.*?</html>)'
ok 17 - contains_pod yes, errors
...
ok 25 - write_html
looks like you failed 1 test of 25.

This must have occurred due to changes made between r35937 -- at which I had the test passing -- and r35953. Let's investigate.

  Changed 6 years ago by jkeenan

  • owner set to allison

Allison,

Can you investigate whether this failure is due to changes introduced in  r35941?

There's an inline comment in the test file that describes the test that failed as "Not the best of tests, but at least something." So maybe the test should be revised to match the new web page used in testing.

Thank you very much.
kid51

  Changed 6 years ago by NotFound

Patch applied in r35958

  Changed 5 years ago by jkeenan

  • owner changed from allison to jkeenan

Test appears to be passing steadily. Closing ticket.

  Changed 5 years ago by jkeenan

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.