Ticket #230 (closed patch: fixed)

Opened 6 years ago

Last modified 6 years ago

[PATCH] add_method tests in t/pmc/class.t no longer seem to need commenting out

Reported by: ronaldws Owned by: jkeenan
Priority: normal Milestone:
Component: none Version:
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform:

Description

Tests were commented out with a comment "TODO not yet implemented". On removing the comment '#' before the call to add_method, it turned out that only one test was really failing out of about eight. That test was trying to call a method directly from a class rather than an object instantiating the class. Since calling a method from an object instantiating a class works, I added a test for a call through the object and just made the call to a method directly from a class a TODO.

Attachments

class.patch Download (1.5 KB) - added by ronaldws 6 years ago.

Change History

Changed 6 years ago by ronaldws

Changed 6 years ago by jkeenan

  • owner set to jkeenan
  • status changed from new to assigned

Changed 6 years ago by jkeenan

  • patch set to applied

Tested successfully on 2 OSes (Linux and Darwin). Applied in  r36042.

Thanks, Ron!

kid51

Changed 6 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

No complaints; no test failures; resolving ticket.

kid51

Note: See TracTickets for help on using tickets.