Ticket #255 (closed patch: fixed)

Opened 6 years ago

Last modified 6 years ago

[PATCH] for the file "compilers/imcc/main.c"

Reported by: gerd Owned by:
Priority: normal Milestone:
Component: imcc Version:
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

Hello,

this little patch is that "parrot -V" shows the year 2009 for Copyright.

Generated with: diff -u compilers/imcc/main.c compilers/imcc/main.c.new > main.c.patch

Gerd Pokorra

Attachments

main.c.patch Download (0.7 KB) - added by gerd 6 years ago.

Change History

Changed 6 years ago by gerd

Changed 6 years ago by jkeenan

The patch is fine ... but I think this is a useful point to ask Allison and the other Parrot Foundation folks where we are headed with respect to copyright.

When I run our coding standards test for copyright, I get this output:

516 $ prove -v t/codingstd/copyright.t 
t/codingstd/copyright....
1..2
ok 1 - Copyright statement exists
ok 2 # SKIP Waiting for decision as to whether copyright dates are necessary
ok
All tests successful.
Files=1, Tests=2,  4 wallclock secs ( 0.01 usr  0.00 sys +  0.39 cusr  0.08 csys =  0.48 CPU)
Result: PASS

That SKIP has been there for at least a year-and-a-half, and probably much longer. Have we gotten any closer to making that decision?

And a follow-up question: Is the Perl Foundation still the copyright holder for the Parrot source code? If not, how should the existing in-file copyright statements be handled?

Thank you very much.
kid51

Changed 6 years ago by allison

  • status changed from new to closed
  • resolution set to fixed

Patch applied in r36696. Thanks, Gerd.

On t/codingstd/copyright.t, that test will never be right, because it requires all copyright statements in the repository to be updated to the current year. The copyright notice on a file should always list

<first year file was modified>-<last year file was modified>

which won't be the same as:

<first year file was modified>-<current year>

if the file wasn't actually updated this year. I committed a fix to the test file in r36698 that tests the right thing, namely that the format of the copyright statement is correct. Left skipped for now until the transition to "Parrot Foundation" is complete. See TT #298.

Resolving this ticket.

Allison

Note: See TracTickets for help on using tickets.