Ticket #259 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

[PATCH] t/configure test failure

Reported by: mikehh Owned by:
Priority: normal Milestone:
Component: none Version: 0.9.0
Severity: medium Keywords:
Cc: Language:
Patch status: new Platform: all

Description

In r36229 petdance modified lib/Parrot/Configure.pm changing the quotes in to die errors from single to double quotes:

'fatal_step' to "fatal_step" and

'verbose-step' to "verbose-step"

this caused t/configure/043-verbose_step.t and t/configure/051-fatal_step.t to fail

 http://smolder.plusthree.com/app/public_projects/report_details/17715

the included patch fixes the quotes in the tests and they now pass.

 http://smolder.plusthree.com/app/public_projects/report_details/17719

Attachments

t_configure.patch Download (1.0 KB) - added by mikehh 5 years ago.

Change History

Changed 5 years ago by mikehh

in reply to: ↑ description   Changed 5 years ago by jkeenan

  • status changed from new to closed
  • resolution set to fixed

Moritz applied mikehh's patches in r36240 and r36241. The tests in question again pass.

However, this is a case where the application of Perl::Critic standards was utterly absurd. When I modified Parrot::Configure to accept the --verbose-step and --fatal-step options, I meant exactly what I typed when I created the failure messages:

die "Argument to 'fatal-step' option must be comma-delimited string of valid configuration steps";

and

die "Argument to 'verbose-step' option must be comma-delimited string of valid configuration steps";

The single quotes were intentional. They focus the reader's attention where it's needed, but they do not carry the connotation of interpolation which double quotes convey to a programmer. The tests were written in conjunction with the error messages, so there was no need to resort to character classes (['"]) in the test's regex.

So, while I'll accept some of the revisions made in r36229, I'm reverting these particular changes to Parrot::Configure and their associated tests as well. Done in r36248.

So, mikehh, while this means I'm reverting your patch, I want to thank you for being vigilant about running perl Configure.pl --test.

Thank you very much.
kid51

Note: See TracTickets for help on using tickets.