Ticket #266 (assigned todo) — at Version 5

Opened 13 years ago

Last modified 13 years ago

Packfile API cleanup: rename Parrot_readbc to Parrot_read_pbc, _loadbc => _load_pbc

Reported by: rurban Owned by: rurban
Priority: normal Milestone:
Component: core Version:
Severity: medium Keywords:
Cc: Language:
Patch status: new Platform:

Description (last modified by rurban) (diff)

Attached is a patch which:

- renames Parrot_readbc to Parrot_pbc_read (as heard on IRC)
- renames Parrot_loadbc to Parrot_pbc_load
- adds a third debug argument to Parrot_pbc_read which is stored in

the returned pf->options member, to be able to react in parrot and in other pbc utils differently.
Used for debugging pbc transformers.

- macrofy TRACE_PACKFILE printing (debug levels 1, 2 and 3)

Rationale: Debugging the pbc reader requires rebuilding libparrot and pdump, but this affects parrot also. parrot should not debug-print pbc transformers while testing. 64-bit pbc unpacking has still broken alignments, 64bit BE and 12-byte floats are untested, so there's still a way to go with this debugging stuff.

Also included is the TT #258 TODO patch "pcb_disassemble options -[bho?], enable roundtrips". I can apply them seperately.

The patch needs a reviewer.

Change History

Changed 13 years ago by rurban

  • owner set to rurban
  • status changed from new to assigned
  • description modified (diff)

Changed 13 years ago by rurban

  • description modified (diff)
  • summary changed from Packfile cleanup: rename Parrot_readbc to Parrot_read_pbc, _loadbc => _load_pbc to Packfile API cleanup: rename Parrot_readbc to Parrot_read_pbc, _loadbc => _load_pbc

Changed 13 years ago by rurban

  • description modified (diff)

Changed 13 years ago by particle

close, but the naming convention is to put the subsystem first, so the functions should be named like Parrot_pbc_{read,load} instead.

~jerry

Changed 13 years ago by rurban

  • description modified (diff)

Changed 13 years ago by rurban

Note: See TracTickets for help on using tickets.