Ticket #278 (closed bug: fixed)
mingw libparrot doublequoting error
Reported by: | rurban | Owned by: | rurban |
---|---|---|---|
Priority: | normal | Milestone: | 0.9.1 |
Component: | none | Version: | trunk |
Severity: | medium | Keywords: | mingw |
Cc: | Language: | ||
Patch status: | new | Platform: | all |
Description (last modified by rurban) (diff)
g++ -o dynlexpad.dll "dynlexpad.o" $(LIBS) -Wl,-L "C:/DOCUME~1/MA RK~1.GLI/test/blib/lib" -shared ""C:/Documents and Settings/mark.glines/test\libparrot.dll""
http://irclog.perlgeek.de/parrot/2009-02-05#i_888107 libparrot_ldflags => "\"$build_dir\\libparrot.dll\"", but dynpmc says # Paths need quoting as they may contain spaces. but the path is already quoted of course.
Since other platforms may also want to use spaces in the build_dir we should rather not special case this, and detect spaces in build_dir and quote them properly, not to have to add pathquotes all over.
destdir or any other targetdir spaces need to to be detected like this, since their are entered by the user and as such properly quoted by the user.
The first hand fix is at http://nopaste.snit.ch/15504 for config/gen/makefiles/dynoplibs_pl.in only