Ticket #288 (closed todo: fixed)

Opened 6 years ago

Last modified 5 years ago

[TODO] config/gen/makefiles/dynpmc_pl.in sub compile_cmd()

Reported by: jkeenan Owned by: jkeenan
Priority: minor Milestone:
Component: configure Version:
Severity: low Keywords: pmc dynpmc
Cc: Language:
Patch status: Platform:

Description

The XXX flag comment below generated a t/codingstd/perlcritic.t failure tonight. (Why it did so tonight for flag comments that have been there for years? No idea.)

sub compile_cmd {
    my ($target, $source) = @_;

    my $dynpmc_include = '';
    if (defined $ENV{DYNPMC_INCLUDE} )
    {
        $dynpmc_include = $ENV{DYNPMC_INCLUDE};
        $dynpmc_include =~ s/,/$PATHQUOTE -I$PATHQUOTE/g;
        $dynpmc_include = "-I" . $PATHQUOTE . $dynpmc_include . $PATHQUOTE . " ";
    }


    # XXX Reference to BGC - need long term solution for passing in include paths
    return
        "$CC " .
        '@cc_o_out@' . $target . " " .
        "-I" . $PATHQUOTE . '@build_dir@@slash@include' . $PATHQUOTE . " " .
        "-I" . $PATHQUOTE . '@build_dir@@slash@src@slash@pmc' . $PATHQUOTE . " " .
        $dynpmc_include . " " .
        "$CFLAGS " .
        $source;
};

So I'm converting it to a ticket. Don't know what BGC is and I don't know why we need a long-term solution. Comments?

Change History

  Changed 6 years ago by jkeenan

  • keywords pmc dynpmc added

Was also reported in TT 290. Retaining this one as open.

follow-up: ↓ 3   Changed 6 years ago by allison

Deprecating the whole script. See TT #338.

in reply to: ↑ 2 ; follow-up: ↓ 5   Changed 5 years ago by jkeenan

  • cc jkeen@… added

Replying to allison:

Deprecating the whole script. See TT #338.

In a subsequent comment, Allison appears to have postponed the deprecation of tools/build/dynpmc_pl. So this issue remains open.

  Changed 5 years ago by jkeenan

  • cc jkeenan added; jkeen@… removed

in reply to: ↑ 3 ; follow-up: ↓ 6   Changed 5 years ago by jkeenan

Replying to jkeenan:

In a subsequent comment, Allison appears to have postponed the deprecation of tools/build/dynpmc_pl. So this issue remains open.

Just to clarify: What we need to know is: What is wrong with the code beneath the comment? What is the problem with include paths? Why doesn't the cited code constitute a long-term solution?

Thank you very much.
kid51

in reply to: ↑ 5 ; follow-up: ↓ 7   Changed 5 years ago by jkeenan

  • status changed from new to assigned
  • owner set to jkeenan
  • cc jkeenan removed
> 
> Just to clarify:  What we need to know is:  
> What is wrong with the code beneath the comment?  
> What is the problem with include paths?  
> Why doesn't the cited code constitute a long-term solution?
> 

Well, in eight months, no one has suggested any answers to these questions. So I propose to yank the comment (config/gen/makefiles/dynpmc_pl.in line 60) and resolve the ticket unless I hear otherwise in seven days.

Thank you very much.
kid51

in reply to: ↑ 6   Changed 5 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

Replying to jkeenan:

Well, in eight months, no one has suggested any answers to these questions. So I propose to yank the comment (config/gen/makefiles/dynpmc_pl.in line 60) and resolve the ticket unless I hear otherwise in seven days.

No objections in the allocated time, so I yanked the comment in r43249.

Closing ticket. Thank you very much.

kid51

Note: See TracTickets for help on using tickets.