Ticket #288 (closed todo: fixed)
[TODO] config/gen/makefiles/dynpmc_pl.in sub compile_cmd()
Reported by: | jkeenan | Owned by: | jkeenan |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | configure | Version: | |
Severity: | low | Keywords: | pmc dynpmc |
Cc: | Language: | ||
Patch status: | Platform: |
Description
The XXX flag comment below generated a t/codingstd/perlcritic.t failure tonight. (Why it did so tonight for flag comments that have been there for years? No idea.)
sub compile_cmd { my ($target, $source) = @_; my $dynpmc_include = ''; if (defined $ENV{DYNPMC_INCLUDE} ) { $dynpmc_include = $ENV{DYNPMC_INCLUDE}; $dynpmc_include =~ s/,/$PATHQUOTE -I$PATHQUOTE/g; $dynpmc_include = "-I" . $PATHQUOTE . $dynpmc_include . $PATHQUOTE . " "; } # XXX Reference to BGC - need long term solution for passing in include paths return "$CC " . '@cc_o_out@' . $target . " " . "-I" . $PATHQUOTE . '@build_dir@@slash@include' . $PATHQUOTE . " " . "-I" . $PATHQUOTE . '@build_dir@@slash@src@slash@pmc' . $PATHQUOTE . " " . $dynpmc_include . " " . "$CFLAGS " . $source; };
So I'm converting it to a ticket. Don't know what BGC is and I don't know why we need a long-term solution. Comments?
Change History
Note: See
TracTickets for help on using
tickets.