HTTP/1.1 -1 Read error in cache disk data: SuccessContent-Type: text/csv; charset="utf-8" Last-Modified: Sat, 22 Jan 2022 04:15:56 GMT Content-length: 1373 Connection: Close Proxy-Connection: Close X-Cache: HIT from web1.osuosl.org Server: ProxyTrack 0.5 (HTTrack 3.49.2) id,summary,reporter,owner,description,type,status,priority,milestone,component,version,severity,resolution,keywords,cc,lang,patch,platform 289,[TODO] config/gen/makefiles/dynpmc_pl.in sub gather_groups_and_libs(),jkeenan,jkeenan,"This '''XXX''' flag comment generated a ''t/codingstd/perlcritic.t'' failure tonight. (Why tonight? After sitting in the file for so long? Don't know.) {{{ # XXX: ordering of libs might be crucial sub gather_groups_and_libs { my @pmcs = @_; my ( %group_files, %group_libs, %pmc_group, %pmc_libs ); for my $pmc (@pmcs) { our $class = retrieve(""$pmc.dump""); # there can be many libs my %libs = %{ $class->{flags}{lib} || {} }; $pmc_libs{$pmc} = \%libs; # There should be at most a single group my $group = $class->{flags}{group} or next; $pmc_group{$pmc} = $group; push @{ $group_files{$group} }, $pmc; $group_libs{$group} ||= {}; foreach my $lib ( keys %libs ) { $group_libs{$group}->{$lib} = 1; } } return (\%group_files, \%group_libs, \%pmc_group, \%pmc_libs); } }}} So I'm converting this to a Trac ticket: Can anyone opine as to whether the ordering of the libs might indeed be crucial? Thank you very much.[[BR]] kid51",todo,closed,minor,,configure,,low,fixed,,,,,