Ticket #329 (closed patch: fixed)

Opened 6 years ago

Last modified 4 years ago

[PATCH] save compiler filename in PCT::HLLCompiler

Reported by: chrisdolan Owned by: pmichaud
Priority: minor Milestone:
Component: PCT Version:
Severity: low Keywords:
Cc: Language:
Patch status: Platform: all

Description

Currently, PCT::HLLCompiler.process_args shifts off the first argument value and drops it on the floor. The attached patch instead stores that value for later use. For Rakudo, for example, this value contains 'perl6.pbc'.

Attachments

hll-compiler-name.patch Download (1.6 KB) - added by chrisdolan 6 years ago.
add compiler_progname property to PCT::HLLCompiler

Change History

Changed 6 years ago by chrisdolan

add compiler_progname property to PCT::HLLCompiler

Changed 5 years ago by jkeenan

Patrick, do you have any comments on this patch?

Thanks.
kid51

Changed 4 years ago by cotto

chrisdolan, can you provide a use case for this feature? It's pretty innocuous and simple enough to appear obviously correct, but how can will this help users of PCT::HLLCompiler?

Changed 4 years ago by coke

tcl's [info nameofexecutable]

could use this.

Changed 4 years ago by cotto

That's good enough for a patch this small. I committed it in r49555. A test should be added for the feature (checking the name of the pbc file used as the compiler), at which point this ticket can be closed.

Changed 4 years ago by pmichaud

On Sat, Oct 16, 2010 at 10:22:27PM -0000, Parrot wrote:
> #329: [PATCH] save compiler filename in PCT::HLLCompiler

Since the time that this patch has been submitted, PCT::HLLCompiler
has added a "%*COMPILING" dynamic lexical hash which is intended
to hold information such as this (instead of creating attributes and
accessor methods for each such compiler attribute we might want
in the future).  I think the %*COMPILING hash is a more flexible
mechanism (especially since it can be set per-compile instead of
per-compiler).

Pm

Changed 4 years ago by pmichaud

  • status changed from new to closed
  • resolution set to fixed

Marking ticket as fixed -- the equivalent capability is available through the %*COMPILING dynamic variable.

Pm

Note: See TracTickets for help on using tickets.