Ticket #343 (closed patch: done)

Opened 5 years ago

Last modified 5 years ago

[patch] forward declare core types (pmc, string, interpreter) to avoid using different declarations in core and extensions

Reported by: NotFound Owned by: NotFound
Priority: normal Milestone:
Component: core Version:
Severity: high Keywords:
Cc: Language:
Patch status: applied Platform: all

Description

This patch adds a header file to forward declare string, pmc and interpreter types to avoid the use of different declarations in core and in extensions/embedding, allowing better type checking by C and C++ compilers. Also moves Parrot_compile_string to embed.h as suggested in the embed draft pdd.

This change will allow embedding without including inappropriate headers or fake PARROT_IN_CORE defines.

Attachments

coretypes.patch Download (10.5 KB) - added by NotFound 5 years ago.

Change History

Changed 5 years ago by NotFound

Changed 5 years ago by NotFound

  • status changed from new to assigned
  • owner set to NotFound

The plan is to commit this patch after the release. If someone has any problem with this, please report as soon as possible.

Changed 5 years ago by NotFound

  • patch set to applied

Applied in r36847

Changed 5 years ago by NotFound

  • status changed from assigned to closed
  • resolution set to done

Several days passed without problems reported, closing ticket.

Note: See TracTickets for help on using tickets.