Ticket #36 (closed bug: fixed)

Opened 6 years ago

Last modified 4 years ago

Harmless test errors on Win32Vista

Reported by: whiteknight Owned by: rblasch
Priority: normal Milestone:
Component: core Version:
Severity: low Keywords:
Cc: Language:
Patch status: Platform: win32

Description

I'm getting two test errors on my Vista machine that look pretty harmless to me. The first one looks like the test just isn't smart enough to understand the stupid ways that the Windows console handles file names:

# Failed test 'prefix' # at t/pmc/config.t line 41. # got: 'c:/users/andrew/documents/parrot' # expected: 'c:/users/andrew/docume~1/parrot' # Looks like you failed 1 test of 3.

And the second one looks like I have some kind of batty permissions setting:

# Failed test 'eval.get_string - same file' # at t/pmc/eval.t line 319. # Exited with error code: 1 # Received: # hello from foo_1 # Permission denied # current instr.: 'main' pc -1 ((unknown file):-1) # called from Sub 'main' pc 35 (C:\Users\Andrew\DOCUME~1\Parrot\t\pmc\eval_10.pir:12) # # Expected: # hello from foo_1

Are these fine to ignore, or should we patch them up?

--Andrew Whitworth

Attachments

short_path_name_win32.patch Download (0.6 KB) - added by chromatic 6 years ago.
Potential fix for the first error.

Change History

  Changed 6 years ago by coke

  • platform set to win32

  Changed 6 years ago by rblasch

  • status changed from new to assigned
  • owner set to rblasch
  • platform win32 deleted

Both issues are not Vista specific. The first one is because Configure uses GetShortPathName to get the 8.3 path, without spaces, if the alias is available. That's where the docume~1 comes from. This issue should be fixed. Note that GetShortPathName tries to return the short name, but will return the long if no shorter version is available.

In the second issue, I think the code tries to reuse the file while it's in use. Specifically, OS.rm can't remove the file and responds with a permission denied. I don't think there's anything that can be done about this on Windows filesystems (NTFS, FAT and variants).

Ron

  Changed 6 years ago by rblasch

  • status changed from assigned to new
  • owner rblasch deleted
  • platform set to win32

  Changed 6 years ago by whiteknight

  • milestone 0.8.2 deleted

bumping this ticket off the 0.8.2 milestone since it's not a blocker and I don't think anybody is working on it.

  Changed 6 years ago by rblasch

  • status changed from new to assigned
  • owner set to rblasch

Changed 6 years ago by chromatic

Potential fix for the first error.

follow-up: ↓ 7   Changed 6 years ago by chromatic

TT #121 tracks the second error, so if we can close the first one, we can close this ticket.

in reply to: ↑ 6   Changed 5 years ago by jkeenan

Replying to chromatic:

TT #121 tracks the second error, so if we can close the first one, we can close this ticket.

The first error, as reported by Whiteknight, was:

# Failed test 'prefix' # at t/pmc/config.t line 41. 
# got: 'c:/users/andrew/documents/parrot' 
# expected: 'c:/users/andrew/docume~1/parrot' 
# Looks like you failed 1 test of 3. 

Andrew, are you still getting this problem?

Thank you very much.
kid51

  Changed 4 years ago by whiteknight

I have not seen this error in some time, but I mention this with two caveats:

1) I have not used Windows Vista for several months. Ron said this shouldn't be an issue, but it's always nice to see passing tests on the same platform where we were seeing errors previously and 2) I do not currently have a usable windows build environment, haven't had one for about a month, and cannot do a test now. When I did have my windows build environment, I don't remember seeing this issue, but I can't test it today.

So, a +0.5 on closing this, because I don't think it's a problem anymore but I can't say definitively that it is not.

  Changed 4 years ago by ronaldws

I run Windows Vista on one of my machines and, just to compare apples to apples, I installed a copy of the parrot build tree under \Users\ron\Documents. Both tests passed there fine. I think you can close.

  Changed 4 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

Thanks to all who contributed to this ticket. I'm taking Ron's hint and am closing this ticket.

kid51

Note: See TracTickets for help on using tickets.