Ticket #372 (closed cage: fixed)

Opened 5 years ago

Last modified 5 years ago

Remove the Slice PMC

Reported by: cotto Owned by:
Priority: normal Milestone: 1.4
Component: none Version:
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

A PMC is not the proper way to implement slices. This PMC is also poorly tested and needs to go away. According to our deprecation policy, the next time this can happen is before the 1.4 (deprecation point) release.

In the meantime, I'll remove all uses of the code from the rest of Parrot to make the removal easy when the time comes.

Change History

follow-up: ↓ 2   Changed 5 years ago by coke

Let's leave the test files; that way we can be reasonably sure we don't break it in the meantime.

in reply to: ↑ 1   Changed 5 years ago by cotto

Replying to coke:

Let's leave the test files; that way we can be reasonably sure we don't break it in the meantime.

That's my intent.

  Changed 5 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

Ripley: I say we take off and nuke the entire site from orbit. It's the only way to be sure.

This PMC is removed in r37546. I don't know why there was a special case in src/packfile.c. It looks like that code does have some test coverage. Removing it didn't cause any test failures so I didn't bother digging any deeper.

Note: See TracTickets for help on using tickets.