Ticket #384 (closed todo: fixed)

Opened 6 years ago

Last modified 6 years ago

pbc_dump -h should not fail on version mismatch

Reported by: rurban Owned by: rurban
Priority: trivial Milestone: 1.0
Component: core Version:
Severity: low Keywords:
Cc: Language:
Patch status: applied Platform:

Description

pbc_dump should not fail too early when the version or uuid check fails on -h. The header should always be printed.

perl tools/dev/pbc_header.pl t/native_pbc/number_3.pbc

        wordsize      =   4
        byteorder     =   1
        floattype     =   0
        parrot_major  =   0
        parrot_minor  =   9
        parrot_patch  =   0
        bc_major      =   3
        bc_minor      =  34
        uuid_type     =   0
        uuid_size     =   0
        pad           =  14
        dir_format    = 16777216, 0, 0, 0

but

pbc_dump.exe -h t\native_pbc\number_3.pbc
PackFile_unpack: This Parrot cannot read bytecode files with version 3.34.
Parrot VM: Can't unpack packfile t\native_pbc\number_3.pbc.
Can't read PBC

Attachments

tt384-pbc_utils.patch Download (14.1 KB) - added by rurban 6 years ago.

Change History

Changed 6 years ago by rurban

  • status changed from new to assigned
  • milestone set to 1.0

The new third Parrot_pbc_read argument should be used for that.

Default: 0 for parrot, pbc_merge, pbc_to_exe, parrot_debugger.

NOTFAIL with 1 for the other pbc_utils: pbc_info, pbc_dump, pbc_disassemble.

Changed 6 years ago by rurban

  • component changed from none to core
  • patch set to new

Changed 6 years ago by rurban

Changed 6 years ago by rurban

  • status changed from assigned to closed
  • resolution set to fixed
  • patch changed from new to applied

applied with r37212.

Note: See TracTickets for help on using tickets.