32/64-bit cpu in smolder report

[rurban]

I miss crucial 32/64bit info on the smolder reports. I want to add it to the cpuarch, similar to amd64 or ia64.

So ppc is either pcc32 or ppc64, alpha is alpha32 or alpha64, ... sun4 should be sparc32 or sparc64. Just to make it clear.

Ok to apply?

--- parrot-svn.orig/lib/Parrot/Harness/Smoke.pm	2009-03-03 19:54:35.671875000 +0100
+++ parrot-svn/lib/Parrot/Harness/Smoke.pm	2009-03-03 20:32:42.390625000 +0100
@@ -100,8 +100,14 @@
 }
 
 sub collect_test_environment_data {
+    # rename sun4 to sparc
+    my $arch = $PConfig{cpuarch} eq 'sun4' ? 'sparc' : $PConfig{cpuarch};
+    # add the 32/64 bit suffix to the cpuarch
+    if ($PConfig{cpuarch} !~ /\d$/) {
+      $arch = $PConfig{cpuarch} . (8*$PConfig{wordsize});
+    }
     return (
-        'Architecture' => $PConfig{cpuarch},
+        'Architecture' => $arch,
         'Compiler'     => _get_compiler_version(),
         'DEVEL'        => $PConfig{DEVEL},
         'Optimize'     => ($PConfig{optimize} || 'none'),

[rg]

Without actually trying it, this looks like it's going to miss right where I'm missing the information the most: sun4.

[rurban]

sun4 yes. I saw that in smolder. This should be fixed also, but elsewhere.

sun4 was replaced 1990 with sparc. There's only intel and Sparc32 and Sparc64.  http://de.wikipedia.org/wiki/Sun-4

So I want for solaris to be there: i386, amd64, sparc or sparc64. maybe for smolder sparc32 is clearer.

gcc calls 32-bit sparc "sparc" and 64bit ultrasparc "sparc64", not sun4. sun4 is ancient history, or?

[rg]

Replying to rurban:

sun4 was replaced 1990 with sparc. There's only intel and Sparc32 and Sparc64.  http://de.wikipedia.org/wiki/Sun-4

Yes, I have no idea who's idea it was to name that arch sun4. I guess it originates in perl using archname=sun4-solaris (I'd consider this a bad idea aswell, but that's their problem ;))

So I want for solaris to be there: i386, amd64, sparc or sparc64. maybe for smolder sparc32 is clearer. gcc calls 32-bit sparc "sparc" and 64bit ultrasparc "sparc64", not sun4.

Yes, autoconf calls it sparc and sparc64, which is a lot better and also what I'd stick with. I'm not sure what we're getting for solaris i386. There's no smolder report for it.

sun4 is ancient history, or?

Exactly. sun4 is m68k hardware that got replaced by sparc a long time ago. However sun continued to call these sun4c and then sun4u (see also the bottom of that Wikipedia page).

While probably a bit hackish, I agree that the proposed patch will improve information on the smolder pages.

+1 to apply.

[rurban]

applied as r37132

[rurban]

additional fixes:

• r37157: fix sparc smolder report +32/64
• r37167: wordsize => opcode_t_size

[Freddy1]

 zend

[jkeenan]

This ticket appears to have been closed by a spammer. The issues originally described by rurban have not been resolved. Reopening.

kid51

[jkeenan]

Inspecting the tags currently available at  our Smolder site, I see reports from ppc32, sparc32 and sparc64. So it seems we have the capacity to add '32' and '64' as needed.

Closing this ticket.

Thank you very much.

kid51