Ticket #40 (closed bug: fixed)

Opened 6 years ago

Last modified 5 years ago

t/pmc/exceptions.t unexpectedly passes

Reported by: whiteknight Owned by: jkeenan
Priority: minor Milestone:
Component: core Version:
Severity: low Keywords: pmc exception
Cc: Language:
Patch status: applied Platform: all

Description

We're getting an unexpected pass in test #30 in t/pmc/exception.t, and it's unexpectedly passing with all runcores. Can we un-TODO this test, or is this just a temporary fluke?

Change History

follow-up: ↓ 2   Changed 6 years ago by coke

I believe this test was reported failing on darwin/PPC.

I recommend un-TODO'ing it, and whichever platforms it fails on can put in a more specific TODO here.

in reply to: ↑ 1 ; follow-up: ↓ 3   Changed 6 years ago by jkeenan

Replying to coke:

I believe this test was reported failing on darwin/PPC. I recommend un-TODO'ing it, and whichever platforms it fails on can put in a more specific TODO here.

It's  still failing on Darwin PPC as of r34891 today.

in reply to: ↑ 2   Changed 6 years ago by jkeenan

This is already been  tracked in RT 60556, as are several other failing tests in this file.

follow-up: ↓ 5   Changed 6 years ago by whiteknight

I haven't been seeing an unexpected PASS on this test recently on my system (Ubuntu 9.04 x86-64). So that means either the test is no longer passing like it was, or that it has been unTODO'd. Any news on which it might be?

in reply to: ↑ 4 ; follow-up: ↓ 6   Changed 5 years ago by jkeenan

  • status changed from new to assigned
  • component changed from none to core
  • patch set to applied
  • platform set to all
  • keywords pmc exception added
  • owner set to jkeenan

Replying to whiteknight:

I haven't been seeing an unexpected PASS on this test recently on my system (Ubuntu 9.04 x86-64). So that means either the test is no longer passing like it was, or that it has been unTODO'd. Any news on which it might be?

At some point in the past[1], this test was marked SKIP rather than TODO. I believe that designation is incorrect. We should SKIP a test if it depends on features/functionality simply not present on the platform on which we are testing. We should TODO otherwise.

Since this test is passing for me on both Linux/i386 and Darwin/PPC, I am both un-SKIPping it and un-TODOing. Let's see how it behaves over the next several days.

Thank you very much.
kid51

in reply to: ↑ 5   Changed 5 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

Replying to jkeenan:

Since this test is passing for me on both Linux/i386 and Darwin/PPC, I am both un-SKIPping it and un-TODOing. Let's see how it behaves over the next several days.

No further failures reported or observed in Smolder reports. Closing ticket.

Note: See TracTickets for help on using tickets.