Ticket #400 (closed patch: fixed)

Opened 5 years ago

Last modified 5 years ago

[PATCH] fix some codingstd test failures at r37112

Reported by: mikehh Owned by: coke
Priority: normal Milestone:
Component: none Version: trunk
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform:

Description

The following codingstd tests failed at r37112:

t/codingstd/c_parens.t ......... 1/3                                         
#   Failed test 'parentheses should not have space immediately               
# after the opening parenthesis nor immediately                              
# before the closing parenthesis                                             
# '                                                                          
#   at t/codingstd/c_parens.t line 123.                                      
#          got: '/home/mhk/parrot/src/ops/cmp.ops: ( P                       
# /home/mhk/parrot/src/ops/cmp.ops: ( P'                                     
#     expected: ''                                                           
# Looks like you failed 1 test of 3.                                         
t/codingstd/c_parens.t ......... Dubious, test returned 1 (wstat 256, 0x100) 


t/codingstd/cuddled_else.t ..... 1/1                                         
#   Failed test 'no cuddled elses'                                           
#   at t/codingstd/cuddled_else.t line 45.                                   
# Cuddled else found in the following files:                                 
# /home/mhk/parrot/lib/Parrot/Harness/Options.pm 103                         
# That's 1 failed files out of 926 files total.                              
# Looks like you failed 1 test of 1.                                         
t/codingstd/cuddled_else.t ..... Dubious, test returned 1 (wstat 256, 0x100) 
Failed 1/1 subtests                                                          

I have included a patch that fixes this.

Cheers,

Michael

Attachments

coding_std_r37112.patch Download (1.1 KB) - added by mikehh 5 years ago.

Change History

Changed 5 years ago by mikehh

Changed 5 years ago by coke

  • owner set to coke

Changed 5 years ago by coke

  • status changed from new to closed
  • resolution set to fixed
  • patch set to applied

Thanks, applied in 37114, along with a mention in CREDITS.

Note: See TracTickets for help on using tickets.