Ticket #403 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

[PATCH] A number of tests need to be updated for the --runcore switch

Reported by: rg Owned by:
Priority: normal Milestone:
Component: none Version:
Severity: medium Keywords:
Cc: rg@… Language:
Patch status: Platform:

Description

... otherwise todo or skip directives are not matched and tests fail.

Attachments

tests.patch Download (6.5 KB) - added by rg 6 years ago.
more_tests.patch Download (4.1 KB) - added by rg 6 years ago.
Rewrite -r to --run-pbc and fix the remaining matches

Change History

Changed 6 years ago by rg

Changed 6 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

committed in r37119. Thanks!

Changed 6 years ago by rg

  • cc rg@… added
  • status changed from closed to reopened
  • resolution fixed deleted

since cores are now selected with --runcore, I've overlooked that -r tests will match that aswell. as a result, any test that is skipped for -r is also skipped for every core. should i prepare a patch to match /-r\b/ or should that rather be remapped as --run-pbc and matched as such?

Changed 6 years ago by coke

My vote is to use the verbose switches where possible.

Changed 6 years ago by rg

Rewrite -r to --run-pbc and fix the remaining matches

Changed 6 years ago by rg

I've just attached a new patch to rewrite -r to --run-pbc.

I'm reusing the existing remap_runcore_opts function, even though -r isn't technically a runcore. Maybe it should just be renamed to remap_opts.

I'm also elimination one test for -r completely, since both checks are identical.

Please review, test and (hopefully) commit :)

Changed 6 years ago by allison

Applied in r37344. Thanks!

Changed 6 years ago by rg

  • status changed from reopened to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.