Ticket #413 (closed todo: fixed)

Opened 5 years ago

Last modified 5 years ago

[TODO] config/auto/alignptrs.pm: inform user to use --64compat for parrot

Reported by: jkeenan Owned by: jkeenan
Priority: normal Milestone: 2.6
Component: core Version: trunk
Severity: medium Keywords: 64-bit
Cc: rurban, doughera Language:
Patch status: Platform:

Description (last modified by jkeenan) (diff)

This TODO statement is found within config/auto/alignptrs.pm:

inform the user to use --64compat for parrot. Milestone v2.6

Perl::Critic flagged it and so we must create a ticket for it.

Change History

  Changed 5 years ago by jkeenan

  • description modified (diff)

follow-up: ↓ 4   Changed 5 years ago by doughera

I don't understand this ticket at all. What is this hypothetical "--64compat" ?

I do see this puzzling note in auto/alignptrs.pm:

# On 8-byte ptr_alignment we cannot read 4-byte pbc's. Warn the user about it.

But surely this is just a limitation of the current pbc reader code. I don't see why the appropriate fix would be to ask 32-bit systems to pay a penalty here instead of changing the reader code. It is certainly possible to read 4-byte integers on an 8-byte system. You may have to read and copy the data, but it can be done. If there's a penalty to be paid, I think it's fair to have the foreign reader pay it.

  Changed 5 years ago by jkeenan

  • cc rurban added

Will CC the original poster of that comment. (My role was just to convert it into Trac ticket.)

in reply to: ↑ 2   Changed 5 years ago by jkeenan

  • owner set to jkeenan
  • status changed from new to assigned
  • cc doughera added

Replying to doughera:

I don't understand this ticket at all. What is this hypothetical "--64compat" ?

Andy,

At some point since I filed this ticket, the original TODO comment vanished. So the original rationale for this ticket is largely gone.

Grepping the repository, the only reference to --64compat I could find was in ./docs/pdds/pdd13_bytecode.pod in a section on Packfiles:

       So we relax pointer alignment strictness on Sparc64, but may add a
       "--64compat" option to parrot in the future to produce 8-byte aligned
       data.  Operations on aligned pointers are much faster than on un-
       aligned pointers.

I do see this puzzling note in auto/alignptrs.pm: # On 8-byte ptr_alignment we cannot read 4-byte pbc's. Warn the user about it.

This comment has also disappeared.

So I propose we close this ticket and open a new one to discuss any related issues.

If there is no objection, I'll do so in 2-3 days.

Thank you very much.
kid51

  Changed 5 years ago by doughera

On Fri, 18 Dec 2009, Parrot wrote:
>  Replying to [comment:2 doughera]:
>  > I don't understand this ticket at all.  What is this hypothetical "--
>  64compat" ?
> 
>  Andy,
> 
>  At some point since I filed this ticket, the original ''TODO'' comment
>  vanished.  So the original rationale for this ticket is largely gone.

Agreed.  If parrot ever wants to implement reading and writing .pbc files 
across different architectures, the alignment issues that originally 
inspired this ticket will probably re-surface, but appropriate tickets can 
be opened then, when there's a well-understood plan.  Close this one.

-- 
    Andy Dougherty		doughera@lafayette.edu


  Changed 5 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

No objection and -- better yet -- a ++ from Andy D! Closing ticket.

Thank you very much.
kid51

Note: See TracTickets for help on using tickets.