[BUG] t/codingstd/c_cppcomments.t reports spurious error at hyperlinks

[jkeenan]

The c_cppcomments.t coding standards test is supposed to detect usage of C++-style comments. Unfortunately, the double forward slashes of such comments are also found in hyperlinks that may reasonably appear in POD inside C-ish files.

Suppose we had a file like this named some.ops:

/*$
 * $Id: experimental.ops 37191 2009-03-08 02:37:10Z coke $$
** some.ops$
*/$
$
VERSION = PARROT_VERSION;$
$
=head1 NAME$
$
experimental.ops - Experimental Opcodes$
L<https://trac.parrot.org>$
$
=cut$

... and then we called:

   $ perl t/codingstd/c_cppcomments.t some.ops

... we would get:

1..1
not ok 1 - no c++ comments
#   Failed test 'no c++ comments'
#   at t/codingstd/c_cppcomments.t line 45.
# C++ comments found in the following files:
# some.ops
# That's 1 failed files out of 1 files total.
# Looks like you failed 1 test of 1.

[coke]

Note that this test wouldn't fail on a C file because then the POD would be encapsulated in a C-style comment. OPS apparently are special and have their pod stripped when converted to C.

Since OPS files aren't C, they should probably be excluded from the tests. (and the generated C files checked instead).

However this gets fixed, other standards tests will probably need similar fixes.

[jkeenan]

Coke applied a quick fix in r37219 but requests that the ticket be kept open for a more complete solution.

[NotFound]

Let's hope nobody write things like:

int a = b ? http:// He!
  other;

[coke]

No big complaints in the 23 months since the quick fix. Closing ticket.